Re: [PATCH ethtool v3 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

[Florian Fainelli <f.fainelli@gmail.com>]

On 11/17/2016 04:08 AM, Allan W. Nielsen wrote:
> From: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
> 
> Add ethtool get and set tunable to access PHY drivers.
> 
> Ethtool Help: ethtool -h for PHY tunables
>     ethtool --set-phy-tunable DEVNAME      Set PHY tunable
>                 [ downshift on|off [count N] ]
>     ethtool --get-phy-tunable DEVNAME      Get PHY tunable
>                 [ downshift ]
> 
> Ethtool ex:
>   ethtool --set-phy-tuanble eth0 downshift on
>   ethtool --set-phy-tuanble eth0 downshift off
>   ethtool --set-phy-tuanble eth0 downshift on count 2


s/tunable/tunable/

Since this will be used as examples for people testing this feature,
this is kind of important to get the example right ;)

Other than that:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>

> 
>   ethtool --get-phy-tunable eth0 downshift
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
> Signed-off-by: Allan W. Nielsen <allan.nielsen@microsemi.com>
> ---

> +.B downshift
> +For operation in cabling environments that are incompatible with 1000BASE-T,
> +PHY device provides an automatic link speed downshift operation.

Might be worth mentioning that this is particularly useful if you are
using a cable which does not have the 4 pairs for instance.
-- 
Florian