From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:46050 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933215AbeBUQsZ (ORCPT ); Wed, 21 Feb 2018 11:48:25 -0500 Received: by mail-pl0-f66.google.com with SMTP id p5so1203120plo.12 for ; Wed, 21 Feb 2018 08:48:24 -0800 (PST) Subject: Re: [PATCH v2 iproute2-next 0/5] bridge: json and color support To: Stephen Hemminger , netdev@vger.kernel.org Cc: Stephen Hemminger References: <20180220192408.19763-1-stephen@networkplumber.org> From: David Ahern Message-ID: Date: Wed, 21 Feb 2018 09:48:53 -0700 MIME-Version: 1.0 In-Reply-To: <20180220192408.19763-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/20/18 12:24 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > This set of patches adds color and full JSON support to bridge command. > > The output format for bridge link command changes so that > $ bridge link show > and > $ ip link show > use same basic format. > > The "-c" flag to bridge changes from shortened form of "-compressvlan" > to shortened form of "-color". Once again this is so that ip > and bridge command take similar options. > > Lastly the JSON output format changes slightly but this > could not impact any real user, because in several cases > the current format was invalid JSON! > > v2 > rebase to updated iproute2-next > use common pretty flag > use common print_name_and_link > > Stephen Hemminger (5): > bridge: implement json pretty print flag > bridge: colorize output and use JSON print library > bridge: add json support for link command > bridge: update man page for new color and json changes > ip: always print interface name in color > > bridge/br_common.h | 4 +- > bridge/bridge.c | 16 ++- > bridge/fdb.c | 279 ++++++++++++++++------------------------- > bridge/link.c | 245 +++++++++++++++++++----------------- > bridge/mdb.c | 354 ++++++++++++++++++++++------------------------------- > bridge/vlan.c | 279 ++++++++++++++++------------------------- > include/utils.h | 2 +- > ip/ipaddress.c | 4 +- > lib/utils.c | 4 +- > man/man8/bridge.8 | 15 ++- > 10 files changed, 521 insertions(+), 681 deletions(-) > series applied to iproute2-next.