From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF1CC282D7 for ; Sat, 2 Feb 2019 21:28:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 421B82173C for ; Sat, 2 Feb 2019 21:28:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P/dCZLZS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbfBBV1a (ORCPT ); Sat, 2 Feb 2019 16:27:30 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:46451 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbfBBV1a (ORCPT ); Sat, 2 Feb 2019 16:27:30 -0500 Received: by mail-io1-f65.google.com with SMTP id s8so8782770iob.13 for ; Sat, 02 Feb 2019 13:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fw4W+pkRlTbrqstA9f8XcsdfqS2wCYmb/MHceTFptRI=; b=P/dCZLZSu1Wd5HUKZvte4BS7fQM7iyfmY73jfEmn6OkhhjGaUbmzQH5NNp5qSDlibp 4bAhdlth3uDyZqQkI0yiMdu9Zf4ChugtfZkW4zOJuMEyAQodGOSRNAfgeLZzXf0ybXDs Fbo7ya0TpqOUbhb8mMm/2qLsijQgwvjYZQj+ZJblzEILwnQsaDgYI26npKTNLpIHQ3T1 GsPw0T/rv/sHIiH2jqD1ddC4i9CJwaPCUGb2vd3Os+55Ku5KXcRVCCH+iEzhSs4X5l45 9qs+dAC2DK2ClS+JPLO+gntlBIaVfloDBsC73C5SIVTDhRZxfJoqMoKlGVn+OTtSA0ks aikw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fw4W+pkRlTbrqstA9f8XcsdfqS2wCYmb/MHceTFptRI=; b=WetakSCZV8JwEKLCnNEG12kEq5HeNAKbS+pYuNez7gvrfqWTDIYFufhZtLuUBBnUia wclqso/xZmcUh2IQ1/81OXQxsqmNEPHuIOhUe7HyABjj+4ribWeh3Fm0R7VtKzRBuMiV 1j+1M5Riqnzv02VLYtlGfHpcffS9HGtPyVFz2eqFHgpRJa0EAusm6DbP21mi+JeGfZDG HtHfVJivSXfepNLnwtaoA5CJIUmCXRxXvDQhMHm+cIdzVc9uD8nb7NpXnbRtNJUxEnxX rbRj/89lnfS/4kgPAxGCsivUaMPqitJXAgJwCT5Ef3WVyJ2XREAMa2FUdoLqWP39hrDM W1FA== X-Gm-Message-State: AHQUAuZlKm0qGJCgGX5ySpSkDZR2m4HQU/3gy+HcbpGIMst1xh9KHNGa /5H8WCDnABNOaDipx0tGJsY= X-Google-Smtp-Source: AHgI3IZpe+6yyJBquHyQ+LpzQLsaaVlNEEAlJIZ6Qk34NmeLRpgHPyWRJ0owbwPHhe/DNSP07NZQIg== X-Received: by 2002:a6b:7402:: with SMTP id s2mr11132579iog.219.1549142848925; Sat, 02 Feb 2019 13:27:28 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:c5c9:9af3:a719:d2e1? ([2601:282:800:fd80:c5c9:9af3:a719:d2e1]) by smtp.googlemail.com with ESMTPSA id f4sm4426829iop.70.2019.02.02.13.27.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Feb 2019 13:27:27 -0800 (PST) Subject: Re: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames To: Jesper Dangaard Brouer , David Miller Cc: mst@redhat.com, makita.toshiaki@lab.ntt.co.jp, jasowang@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, hawk@kernel.org, =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= References: <1548934830-2389-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <20190131101516-mutt-send-email-mst@kernel.org> <20190131.094523.2248120325911339180.davem@davemloft.net> <20190131211555.3b15c81f@carbon> From: David Ahern Message-ID: Date: Sat, 2 Feb 2019 14:27:26 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190131211555.3b15c81f@carbon> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: >> >> David, Jesper, care to chime in where we ended up in that last thread >> discussion this? > > IHMO packets RX and TX on a device need to be accounted, in standard > counters, regardless of XDP. For XDP RX the packet is counted as RX, > regardless if XDP choose to XDP_DROP. On XDP TX which is via > XDP_REDIRECT or XDP_TX, the driver that transmit the packet need to > account the packet in a TX counter (this if often delayed to DMA TX > completion handling). We cannot break the expectation that RX and TX > counter are visible to userspace stats tools. XDP should not make these > packets invisible. Agreed. What I was pushing on that last thread was Rx, Tx and dropped are all accounted by the driver in standard stats. Basically if the driver touched it, the driver's counters should indicate that. The push back was on dropped packets and whether that counter should be bumped on XDP_DROP.