From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2FDC37122 for ; Tue, 22 Jan 2019 01:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A29A52085A for ; Tue, 22 Jan 2019 01:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548120507; bh=q4ROw0aNvpo+THl93XXEBL5M3Un+0danVzy1weBJuPw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=s60M1PYlO5h0crBwh+yrHc6rROL3/7ped7iU43ggo5WSRH9OCt+wo4ZvgITRb9+Qi ihn0QMcWKGaCBmdyzAYDXXalxix1IIhCLcLT/vbZMtJhiwryWVBYLmlcZlrAK6pIAj 0PQcgWx60wUV5iHBUAvy8pzxBbFrhTWu3wO1Etqs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfAVB2Z (ORCPT ); Mon, 21 Jan 2019 20:28:25 -0500 Received: from icp-osb-irony-out2.external.iinet.net.au ([203.59.1.155]:23278 "EHLO icp-osb-irony-out2.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbfAVB2Y (ORCPT ); Mon, 21 Jan 2019 20:28:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AFAAB4cUZc/zXSMGcNVRkBAQEBAQE?= =?us-ascii?q?BAQEBAQEHAQEBAQEBgVQBAQEBAQELAYQShAGUUAEBB4EQJYNahVmQSYR5AoM?= =?us-ascii?q?DNwYNAQMBAQEBAQEChl8BAQEBAyMVQRALDQgDAgImAgJXBg0GAgEBgx6Bdas?= =?us-ascii?q?XcYEvGoUphGSBC4FziVp4gQeBEScMgl+BQYZJglcCkFORTQmSFQYYijoDh1e?= =?us-ascii?q?ceYF4MxoIKAiDJ4IzHo4dYIsLAQE?= X-IPAS-Result: =?us-ascii?q?A2AFAAB4cUZc/zXSMGcNVRkBAQEBAQEBAQEBAQEHAQEBA?= =?us-ascii?q?QEBgVQBAQEBAQELAYQShAGUUAEBB4EQJYNahVmQSYR5AoMDNwYNAQMBAQEBA?= =?us-ascii?q?QEChl8BAQEBAyMVQRALDQgDAgImAgJXBg0GAgEBgx6BdasXcYEvGoUphGSBC?= =?us-ascii?q?4FziVp4gQeBEScMgl+BQYZJglcCkFORTQmSFQYYijoDh1eceYF4MxoIKAiDJ?= =?us-ascii?q?4IzHo4dYIsLAQE?= X-IronPort-AV: E=Sophos;i="5.56,504,1539619200"; d="scan'208";a="181135429" Received: from unknown (HELO [10.44.0.22]) ([103.48.210.53]) by icp-osb-irony-out2.iinet.net.au with ESMTP; 22 Jan 2019 09:28:04 +0800 Subject: Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC To: Andrew Lunn Cc: sean.wang@mediatek.com, bjorn@mork.no, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, rene@vdorst.com, john@phrozen.org, neil@brown.name References: <20190121071140.23089-1-gerg@kernel.org> <20190121071140.23089-3-gerg@kernel.org> <20190121170442.GH8620@lunn.ch> From: Greg Ungerer Message-ID: Date: Tue, 22 Jan 2019 11:28:03 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190121170442.GH8620@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 22/1/19 3:04 am, Andrew Lunn wrote: > On Mon, Jan 21, 2019 at 05:11:39PM +1000, gerg@kernel.org wrote: >> From: Greg Ungerer >> >> The MediaTek MT7621 SoC device contains a 7530 switch, and the existing >> linux kernel 7530 DSA switch driver can be used with it. >> >> The bulk of the changes required stem from the 7621 having different >> regulator and pad setup. The existing setup of these in the 7530 >> driver appears to be very specific to its implemtation in the Mediatek >> 7623 SoC. (Not entirely surprising given the 7623 is a quad core ARM >> based SoC, and the 7621 is a dual core, dual thread MIPS based SoC). >> >> Create a new devicetree type, "mediatek,mt7621", to support the 7530 >> switch in the 7621 SoC. There appears to be no usable ID register to >> distinguish it from a 7530 in other hardware at runtime. This is used >> to carry out the appropriate configuration and setup. >> >> Signed-off-by: Greg Ungerer > > Reviewed-by: Andrew Lunn Thanks Andrew, I'll add those reviewed by tags. Regards Greg