From: "SkyLake Huang (黃啟澤)" <SkyLake.Huang@mediatek.com>
To: "andrew@lunn.ch" <andrew@lunn.ch>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dqfext@gmail.com" <dqfext@gmail.com>,
"Steven Liu (劉人豪)" <steven.liu@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"daniel@makrotopia.org" <daniel@makrotopia.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH net-next 6/9] net: phy: mediatek: Hook LED helper functions in mtk-ge.c
Date: Mon, 7 Oct 2024 10:43:30 +0000 [thread overview]
Message-ID: <b8f2736312bf424262e2327a711c0366da2ce18f.camel@mediatek.com> (raw)
In-Reply-To: <3e27eddb-91c6-4903-9de5-f3df8098a38c@lunn.ch>
On Sun, 2024-10-06 at 23:32 +0200, Andrew Lunn wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> > +static int mt753x_phy_led_blink_set(struct phy_device *phydev, u8
> index,
> > + unsigned long *delay_on,
> > + unsigned long *delay_off)
> > +{
> > +struct mtk_gephy_priv *priv = phydev->priv;
> > +bool blinking = false;
> > +int err = 0;
>
> There is no need to set err.
>
> > +
> > +err = mtk_phy_led_num_dly_cfg(index, delay_on, delay_off,
> &blinking);
> > +if (err < 0)
> > +return err;
>
>
> Andrew
>
> ---
> pw-bot: cr
I'll fix this in next version. Thx!
BRs,
Sky
next prev parent reply other threads:[~2024-10-07 10:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 10:24 [PATCH net-next 0/9] net: phy: mediatek: Introduce mtk-phy-lib which integrates common part of MediaTek's internal ethernet PHYs Sky Huang
2024-10-04 10:24 ` [PATCH net-next 1/9] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-10-06 21:19 ` Andrew Lunn
2024-10-07 6:38 ` kernel test robot
2024-10-04 10:24 ` [PATCH net-next 2/9] net: phy: mediatek: Fix spelling errors and rearrange variables Sky Huang
2024-10-06 21:20 ` Andrew Lunn
2024-10-04 10:24 ` [PATCH net-next 3/9] net: phy: mediatek: Move LED helper functions into mtk phy lib Sky Huang
2024-10-06 21:28 ` Andrew Lunn
2024-10-07 4:30 ` SkyLake Huang (黃啟澤)
2024-10-07 12:50 ` Andrew Lunn
2024-10-04 10:24 ` [PATCH net-next 4/9] net: phy: mediatek: Improve readability of mtk-phy-lib.c's mtk_phy_led_hw_ctrl_set() Sky Huang
2024-10-06 21:29 ` Andrew Lunn
2024-10-04 10:24 ` [PATCH net-next 5/9] net: phy: mediatek: Integrate read/write page helper functions Sky Huang
2024-10-06 21:29 ` Andrew Lunn
2024-10-04 10:24 ` [PATCH net-next 6/9] net: phy: mediatek: Hook LED helper functions in mtk-ge.c Sky Huang
2024-10-06 21:32 ` Andrew Lunn
2024-10-07 10:43 ` SkyLake Huang (黃啟澤) [this message]
2024-10-04 10:24 ` [PATCH net-next 7/9] net: phy: mediatek: add MT7530 & MT7531's PHY ID macros Sky Huang
2024-10-06 21:32 ` Andrew Lunn
2024-10-04 10:24 ` [PATCH net-next 8/9] net: phy: mediatek: Change mtk-ge-soc.c line wrapping Sky Huang
2024-10-04 12:07 ` Russell King (Oracle)
2024-10-07 10:52 ` SkyLake Huang (黃啟澤)
2024-10-04 10:24 ` [PATCH net-next 9/9] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2024-10-04 22:43 ` [PATCH net-next 0/9] net: phy: mediatek: Introduce mtk-phy-lib which integrates common part of MediaTek's internal ethernet PHYs Jakub Kicinski
2024-10-07 10:59 ` SkyLake Huang (黃啟澤)
2024-10-09 1:48 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f2736312bf424262e2327a711c0366da2ce18f.camel@mediatek.com \
--to=skylake.huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steven.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).