From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8EB39B94D for ; Thu, 2 Jul 2026 07:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782978121; cv=none; b=o4JtSArPDmRKC/wREIJWGpnoA8rHVtTwBETZ6YJGJ9EbzPBPHb4CQqsbXuQaR2RL2T65CXprYxz/r0ns+UR66Sk+ea97kDHKHqeLMMt0+Wp5ufWsSgC1hC7iXVfg/ZEb+QNSVlnrNKzXUE3Y9ekh1q04HrsgVKPMxqPctahiNJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782978121; c=relaxed/simple; bh=Jy7te9F4JzjiJ24kXaDzZA0x2YkjrWkIuXyfcffXSNI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pd6buqF8jAie0kboaKBU8DKB9NUcvAIU0HORnb9PTEnTJSInZbvWqXk6FISgBjq1wVZ4r/WseA0ogtB9Ke+8cUkiEGEmE/VzNDb3spqOq9wavHZCnJrkDrGatx+TWKbhezMBgrukQwppZBQqncXk2BotVS4B+TP7xuG7gljF0dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z0zIwPb8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hs9gKVEx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z0zIwPb8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hs9gKVEx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782978116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UfJYqrcmN2j5NYMZu30t1ga7TK1DhGbiNFDYQD6B84Q=; b=Z0zIwPb8oRkrsuGCuWqd3ZxAQO7RVfUwbBlCamBShIrhSNrniOQnD70h2vrbsfFuhB0P/d 0fQqDzfYkUF7hMtwMkdaN/IB0wTtjGWkr0k8mUyWjqkeck5wR6X0lniw5MA0TpI/Wu2nNQ 3xGDmy5nglU9AYm688Sq29C/axCrOrE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-1HjqwXoENnungdWDRb0zAw-1; Thu, 02 Jul 2026 03:41:54 -0400 X-MC-Unique: 1HjqwXoENnungdWDRb0zAw-1 X-Mimecast-MFC-AGG-ID: 1HjqwXoENnungdWDRb0zAw_1782978114 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-493a6fe9ebdso9339895e9.0 for ; Thu, 02 Jul 2026 00:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782978113; x=1783582913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UfJYqrcmN2j5NYMZu30t1ga7TK1DhGbiNFDYQD6B84Q=; b=hs9gKVExnvSis062Ar9tXMTNdD22HQOGQSwfUnQ0WYd6z3thW8f5O9lC+ho9k6OsX6 4TBT3ads+oNnd9iB6RJ42GQcXnZAyX8O9qOFtl/127dP9OpUIcE6jQMEIN5GtxPln4IF VYuvWm/16+O+W5thcbB+wV/6GuyCRtoB/wK9vB3c3X61zm5J9ZJu9T9qYq2WaGH79WVf HLSCxfKTgUYBzt0J28dmXFQ/xLlrnYDNT8hmiZPiMLv0AP/S2E6/l4z+/r8PkQ1vqytG 415rB6p0QD8JzVVZzFcuRb1r75j6TtX89Ns2qrnPP9JjO/wt1604hx8mYDtGVARpTNYM WTmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782978113; x=1783582913; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UfJYqrcmN2j5NYMZu30t1ga7TK1DhGbiNFDYQD6B84Q=; b=V5QF3CeVdB6IfHgWJIqX9GSmH8oKjL+Mf6dz4YqdYr2v6esNzpNvn5SqweAmbpDER4 piNl5IwxeZQvwb1WBEbTrzuZvBGCvMKHa0vHgmCnmeG7L/ZXAKD7PPZ0WnKbQSO1LNmJ rqP6DnPFXbC4cq7VP8lQvQ2OruJ113YgqCr8cUa9lq/ajLdCffcKy051vPxnQEF32IlA cPayA6OzZ8i9rHvVJmeNQ+Hx1t6ly2Bt0Fu5uVgfD5QFr3y25sNet+IYJb3z9u4x0y9+ POs8o9OsRNlSp805TUqDtYAmtdu9Mbh+kLZMZYEsUGm7a0wjGIPkli2uJh5FE5TzuMzm /izw== X-Forwarded-Encrypted: i=1; AFNElJ/VJiBg3HeCGBFDZjzspAMqHF3EJYT07DASo2m1SYimQOql+zdRpJ1kVYx3zVKZ+WcJysZcovY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5npq7cGXiuBzOtQOhBI0Bq55P0oFac3WXt/5+7aAtWvTLMZMU 1Vg27s1aq9Z++crcgtvivk//WzvfnDtrEuKBGfYmoX0+dqh1HYfF9/ohBC48CwqJGGbrmPeZNwj XGQMueUOckGE3UDRd3DvZP0orzmflGwXBkgDqGZKA4Sv8kcS1QlDtIAEAWQ== X-Gm-Gg: AfdE7ckuURBPGTBU1PqfzMZEM91EnyU3ub0L6zwiEZ3Z4jwByY8Js3stlPFAfO5LEzq 0ucFsSZqEVF28xwmqHyDm8+0/0pKR6k1hT/N3KN8AhQJHrUCojzOmLZmI3EQtfqJAJYhThFx9E7 An2ZKl9zB2NBRFTfYiWDW6M9P0mTtpdgiDyZpQWz+OMBd5LshGihGIfpBLNBAlFAbYqZSgzCdA8 sc01a3pp0f+jsP2K7Z3uXA1SYQlV2nC7u5tLSFhB8HOe7bVNFl5DZd3Omzh5iVw9DHIDO+wI6vJ CotwVpj4RmhWSRpFVn2synXo+VTiQDB3esZG6tiNuSmpouygMSYF59n5v0hC349vG9qvg6Vy3Yj jXEe21QjDatp+U0071J2G3NXJcQxkjreauekMCFEG/oLfNvCB3tzjfFgq2bsJM27qITnJs3RbQZ UO5rSJAui1Kw== X-Received: by 2002:a05:600c:810b:b0:493:b61c:72c3 with SMTP id 5b1f17b1804b1-493c2b99c43mr64303615e9.32.1782978113471; Thu, 02 Jul 2026 00:41:53 -0700 (PDT) X-Received: by 2002:a05:600c:810b:b0:493:b61c:72c3 with SMTP id 5b1f17b1804b1-493c2b99c43mr64303185e9.32.1782978112913; Thu, 02 Jul 2026 00:41:52 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:2eb7:f61a:75:4534? ([2a0d:3344:5521:6b10:2eb7:f61a:75:4534]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6377479sm28151965e9.15.2026.07.02.00.41.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 00:41:52 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 09:41:50 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next V4 4/6] devlink: Apply eswitch mode boot defaults To: Mark Bloch , Jiri Pirko , Eric Dumazet , Jakub Kicinski , Simon Horman Cc: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Jonathan Corbet , Shuah Khan , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org References: <20260629182102.245150-1-mbloch@nvidia.com> <20260629182102.245150-5-mbloch@nvidia.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260629182102.245150-5-mbloch@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/29/26 8:20 PM, Mark Bloch wrote: > Apply parsed devlink_eswitch_mode= defaults after devlink registration > and after successful reload. > > devl_register() may still be called before the device is ready for an > eswitch mode change, so keep a per-devlink delayed work item and pending > flag for the registration path. Registration queues the work, and the > worker tries to take the devlink instance lock. > > If the lock is busy, the worker requeues itself with a delay. > > For successful reloads that performed DRIVER_REINIT, devlink_reload() > already holds the devlink instance lock and the driver has completed > reload_up(). Clear pending work and apply the default directly from the > reload path instead of queueing work. > > If a user sets eswitch mode through netlink before the pending > registration work runs, clear the pending flag so the queued default does > not override that user request. Cancel pending default apply work when > freeing the devlink instance. > > Signed-off-by: Mark Bloch > --- > net/devlink/core.c | 198 +++++++++++++++++++++++++++++++----- > net/devlink/dev.c | 6 ++ > net/devlink/devl_internal.h | 5 + > 3 files changed, 182 insertions(+), 27 deletions(-) > > diff --git a/net/devlink/core.c b/net/devlink/core.c > index 5126509a9c4e..998e4ffd5dce 100644 > --- a/net/devlink/core.c > +++ b/net/devlink/core.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -22,8 +23,12 @@ DEFINE_XARRAY_FLAGS(devlinks, XA_FLAGS_ALLOC); > > static char *devlink_default_esw_mode_param; > static bool devlink_default_esw_mode_match_all; > +static bool devlink_default_esw_mode_enabled; > static enum devlink_eswitch_mode devlink_default_esw_mode; > static LIST_HEAD(devlink_default_esw_mode_nodes); > +static struct workqueue_struct *devlink_default_esw_mode_wq; > + > +#define DEVLINK_DEFAULT_ESW_MODE_APPLY_DELAY msecs_to_jiffies(100) > > struct devlink_default_esw_mode_node { > struct list_head list; > @@ -166,6 +171,7 @@ static void __init devlink_default_esw_mode_nodes_clear(void) > } > > devlink_default_esw_mode_match_all = false; > + devlink_default_esw_mode_enabled = false; > } > > static int __init devlink_default_esw_mode_parse(char *str) > @@ -192,14 +198,113 @@ static int __init devlink_default_esw_mode_parse(char *str) > return err; > > err = devlink_default_esw_mode_handles_parse(handles); > - if (err) > + if (err) { > devlink_default_esw_mode_nodes_clear(); > - else > + } else { > devlink_default_esw_mode = esw_mode; > + devlink_default_esw_mode_enabled = true; > + } > > return err; > } > > +static bool devlink_default_esw_mode_match(struct devlink *devlink) > +{ > + const char *bus_name = devlink_bus_name(devlink); > + const char *dev_name = devlink_dev_name(devlink); > + struct devlink_default_esw_mode_node *node; > + > + if (devlink_default_esw_mode_match_all) > + return true; > + > + node = devlink_default_esw_mode_node_find(bus_name, dev_name); > + return !!node; > +} > + > +void devlink_default_esw_mode_apply(struct devlink *devlink) > +{ > + const struct devlink_ops *ops = devlink->ops; > + int err; > + > + devl_assert_locked(devlink); > + > + if (!devlink_default_esw_mode_match(devlink)) > + return; > + > + if (!ops->eswitch_mode_set) { > + if (!devlink_default_esw_mode_match_all) > + devl_warn(devlink, > + "devlink_eswitch_mode= selected this device but eswitch mode setting is not supported\n"); Not a very strong opinion on my side, but I *think* it would be more consistent to emit this warning even for devlink_default_esw_mode_match_all /P