From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0580117B425 for ; Fri, 23 Jan 2026 22:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769207553; cv=none; b=K1DEnbreEAMizqiEs4dBHq1JNAdhR2t7Qz4ehUYYr2tyOAQwfh/dz+riNNEY1Zy9AyD0RPdlgPPA1onusAn+4jTIWU/+cm4QK6lpHawHRp3IIIijqjVzQvJcHwdm0PDvVVOIdE5gmyoSfsgqVbaX0xPOl4gkNIsXfwcfFocdbxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769207553; c=relaxed/simple; bh=z8IlIXh47dOFdPn/7YG8QvPpbpmFtqMaCCfJQd7NMlI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SCRIrUYIEzyCvkM9jYd9kcGZmC4sJTLcPScPu3dldxnt5T79uSFH7pv103sU+7X2pUVYI4aoBYRNeIjAiZVwn9U23tgqv0yPO5bjow56uJr1d2nSRqmMVk/Kw7mw1P2BEn1Km7UgO95B5WNMdOVUZsxKJagbELE+gvmiZHRfrN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EduCrgBt; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EduCrgBt" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2b70abe3417so6412734eec.0 for ; Fri, 23 Jan 2026 14:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769207551; x=1769812351; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6q7jSvteo768fX3RDKijF3HLXLbv8PUQY59d7KtxMqQ=; b=EduCrgBtqMpAN5HLx9K2Hnmaz6PAYaUKFrVq87mWzk+M51Az6xDu9NxKvPDhvczWew hLITVJmvZFSExNTBReX3HjLzJfNA8XKMaNzHN7e+XupoA1it+bmWcFbdz0jJUZ2ipYZh lhx1bxW4oX1lmR38P3WMn/8jzro3ibC+XqHh8LfG27AIdB7ZkUs52jotTQWIYebsrsuq QCgKaeVCGJ3fxGGPvXA7uCouYr/EheGM/Vuz66Vp0I3uHtSpBLKO/GSXtgQenc2KO5Zn 2iVfweZGkT2T6DWE10+DtQa+7gNvWiZwUjOf2MsCY+027+BsO7epz3Gh8QsVcFyVNPMl am2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769207551; x=1769812351; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6q7jSvteo768fX3RDKijF3HLXLbv8PUQY59d7KtxMqQ=; b=u7dLMQ26VwWog+AZQndNBqlMIb47DhHa6fcOhMMu9s9FEoTcWtVclfdXU5WeJ5VsEP hctEyXL2ns/wyufZkGZW89HCXQkfgroQnR51g3Kw4zpSMdIpb6cxVVDPAnEjokU93TeY Od8wjO/CyAIeHFtGDDV2iAZ+TgSxkgL/0rZH14ZNkxPqPS+OrYcSsSw/rlQkZFDIFa1i RZXvOK6y4LzMIb7KSaEZF2gqI1kBWBfSdNf7rN6jQw64BaXPTZCNv79WZp5lwdXNMvdp fA4i4I8+41Pum098N8twUCqhCyrjQF7lXhP/2BywbKAmV+yj0gDWi9E27Ho3O/qFQO6H 9kVQ== X-Forwarded-Encrypted: i=1; AJvYcCVMDfXt2aVsRpJOG6KV8Q7w9dzufjdaVe90Y98RWrsLzC97RzrKSD6RMRhMtGiBL26TLwpH1cs=@vger.kernel.org X-Gm-Message-State: AOJu0Yygm/0K4PaqXR35mSWu7d7/A+Ce1XKSmHAGLv9zwRmCZwF6gp/j aa3AGg/7UTQaPxuwm8+AzhgPcKEHH4YH0GxYr39weqHDgZbuNsTAck0U X-Gm-Gg: AZuq6aIKiqUrdo7r/5hvg49yqRiaSN9b4oO3llqgDcw6mmZRuLKjyJTI6W6hW2hCJg5 2oCGmBRdvMBKH0iKxDGbPhYkHDMxYrDXIIrRl/PoW8NO77RrQXX7ydshSLLCU8mHgJU1jwGxG/M 1eeN/b/OsfUtTbtfaTLA7IDrD/ILXymOixCA23sNcaP6JCQkxTxSiwCdbyWV0Ae669Is7wtw4WL hiIhTAhjbvt0SHlyY14MogIe8FQRQjDcnK+Kkg9GkjLBN3a06bUtal/7JL+1Lg8jL8wsKpZACNb UKtkJBsKXT5ig+9GlDC2vU+0es7kwikBFez+MwalNQjPHm6+8RwVqB34jLNEoZ6mzURY1SQDjSZ hCepttwyVGYYg/N22mnwdGOyTQkkngmfs2v7QPuUdfYpiVlfuJ4zZ6h4PpfV2fCSS5yfJHydpJ/ abAKUT4DQ7kwhiE/l/9+ut X-Received: by 2002:a05:7300:230a:b0:2af:674e:bc73 with SMTP id 5a478bee46e88-2b74274cff4mr1359399eec.7.1769201226027; Fri, 23 Jan 2026 12:47:06 -0800 (PST) Received: from [192.168.4.196] ([73.222.117.172]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73a691b1esm4476320eec.3.2026.01.23.12.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jan 2026 12:47:05 -0800 (PST) Message-ID: Date: Fri, 23 Jan 2026 12:47:02 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH bpf-next v3 09/12] selftests/bpf: Add tests for memcg_bpf_ops To: Hui Zhu , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Peter Zijlstra , Miguel Ojeda , Nathan Chancellor , Kees Cook , Tejun Heo , Jeff Xu , mkoutny@suse.com, Jan Hendrik Farr , Christian Brauner , Randy Dunlap , Brian Gerst , Masahiro Yamada , davem@davemloft.net, Jakub Kicinski , Jesper Dangaard Brouer , Willem de Bruijn , Jason Xing , Paul Chaignon , Anton Protopopov , Amery Hung , Chen Ridong , Lance Yang , Jiayuan Chen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Hui Zhu , Geliang Tang References: Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Hui, On 1/23/26 1:00 AM, Hui Zhu wrote: > From: Hui Zhu > > Add a comprehensive selftest suite for the `memcg_bpf_ops` > functionality. These tests validate that BPF programs can correctly > influence memory cgroup throttling behavior by implementing the new > hooks. > > The test suite is added in `prog_tests/memcg_ops.c` and covers > several key scenarios: > > 1. `test_memcg_ops_over_high`: > Verifies that a BPF program can trigger throttling on a low-priority > cgroup by returning a delay from the `get_high_delay_ms` hook when a > high-priority cgroup is under pressure. > > 2. `test_memcg_ops_below_low_over_high`: > Tests the combination of the `below_low` and `get_high_delay_ms` > hooks, ensuring they work together as expected. > > 3. `test_memcg_ops_below_min_over_high`: > Validates the interaction between the `below_min` and > `get_high_delay_ms` hooks. > > The test framework sets up a cgroup hierarchy with high and low > priority groups, attaches BPF programs, runs memory-intensive > workloads, and asserts that the observed throttling (measured by > workload execution time) matches expectations. > > The BPF program (`progs/memcg_ops.c`) uses a tracepoint on > `memcg:count_memcg_events` (specifically PGFAULT) to detect memory > pressure and trigger the appropriate hooks in response. This test > suite provides essential validation for the new memory control > mechanisms. > > Signed-off-by: Geliang Tang > Signed-off-by: Hui Zhu > --- [..] > diff --git a/tools/testing/selftests/bpf/prog_tests/memcg_ops.c b/tools/testing/selftests/bpf/prog_tests/memcg_ops.c > new file mode 100644 > index 000000000000..9a8d16296f2d > --- /dev/null > +++ b/tools/testing/selftests/bpf/prog_tests/memcg_ops.c > @@ -0,0 +1,537 @@ [..] > + > +static void > +real_test_memcg_ops_child_work(const char *cgroup_path, > + char *data_filename, > + char *time_filename, > + int read_times) > +{ > + struct timeval start, end; > + double elapsed; > + FILE *fp; > + > + if (!ASSERT_OK(join_parent_cgroup(cgroup_path), "join_parent_cgroup")) > + goto out; > + > + if (env.verbosity >= VERBOSE_NORMAL) > + printf("%s %d begin\n", __func__, getpid()); > + > + gettimeofday(&start, NULL); > + > + if (!ASSERT_OK(write_file(data_filename), "write_file")) > + goto out; > + > + if (env.verbosity >= VERBOSE_NORMAL) > + printf("%s %d write_file done\n", __func__, getpid()); > + > + if (!ASSERT_OK(read_file(data_filename, read_times), "read_file")) > + goto out; > + > + gettimeofday(&end, NULL); > + > + elapsed = (end.tv_sec - start.tv_sec) + > + (end.tv_usec - start.tv_usec) / 1000000.0; > + > + if (env.verbosity >= VERBOSE_NORMAL) > + printf("%s %d end %.6f\n", __func__, getpid(), elapsed); > + > + fp = fopen(time_filename, "w"); > + if (!ASSERT_OK_PTR(fp, "fopen")) > + goto out; > + fprintf(fp, "%.6f", elapsed); > + fclose(fp); > + > +out: > + exit(0); > +} > + [..] > +static void real_test_memcg_ops(int read_times) > +{ > + int ret; > + char data_file1[] = "/tmp/test_data_XXXXXX"; > + char data_file2[] = "/tmp/test_data_XXXXXX"; > + char time_file1[] = "/tmp/test_time_XXXXXX"; > + char time_file2[] = "/tmp/test_time_XXXXXX"; > + pid_t pid1, pid2; > + double time1, time2; > + > + ret = mkstemp(data_file1); > + if (!ASSERT_GT(ret, 0, "mkstemp")) > + return; > + close(ret); > + ret = mkstemp(data_file2); > + if (!ASSERT_GT(ret, 0, "mkstemp")) > + goto cleanup_data_file1; > + close(ret); > + ret = mkstemp(time_file1); > + if (!ASSERT_GT(ret, 0, "mkstemp")) > + goto cleanup_data_file2; > + close(ret); > + ret = mkstemp(time_file2); > + if (!ASSERT_GT(ret, 0, "mkstemp")) > + goto cleanup_time_file1; > + close(ret); > + > + pid1 = fork(); > + if (!ASSERT_GE(pid1, 0, "fork")) > + goto cleanup; > + if (pid1 == 0) > + real_test_memcg_ops_child_work(CG_LOW_DIR, > + data_file1, > + time_file1, > + read_times); Would it be better to call exit() after real_test_memcg_ops_child_work() instead of within it? This way the fork/exit/wait logic is contained in the same scope making the lifetimes easier to track. I had to go back and search for the call to exit() since at a glance this function appears to proceed to call fork() and waitpid() from within both parent and child procs (though it really does not).