From: Florian Fainelli <f.fainelli@gmail.com>
To: Lev Urusov <urusov@granch.ru>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: ks8995: Fix bug while selecting sysfs node size
Date: Thu, 9 Mar 2017 16:10:34 -0800 [thread overview]
Message-ID: <b90f6157-b8d1-a49f-dbba-8bcc301229cb@gmail.com> (raw)
In-Reply-To: <1489047937-11798-1-git-send-email-urusov@granch.ru>
On 03/09/2017 12:25 AM, Lev Urusov wrote:
> From: Lev Urusov <urusov@granch.ru>
>
> The driver will not be able to take into account the correct number
> of device SPI registers if it is not equal to 128.
>
> Signed-off-by: Lev Urusov <urusov@granch.ru>
Well, seems like someone already fixed that:
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=239870f2a0ebf75cc8f6d987dc528c5243f93d69
> ---
> drivers/net/phy/spi_ks8995.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
> index 93ffedf..f084725 100644
> --- a/drivers/net/phy/spi_ks8995.c
> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -491,8 +491,8 @@ static int ks8995_probe(struct spi_device *spi)
> if (err)
> return err;
>
> - ks->regs_attr.size = ks->chip->regs_size;
> memcpy(&ks->regs_attr, &ks8995_registers_attr, sizeof(ks->regs_attr));
> + ks->regs_attr.size = ks->chip->regs_size;
>
> err = ks8995_reset(ks);
> if (err)
>
--
Florian
prev parent reply other threads:[~2017-03-10 0:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 8:25 [PATCH] net: phy: ks8995: Fix bug while selecting sysfs node size Lev Urusov
2017-03-10 0:10 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90f6157-b8d1-a49f-dbba-8bcc301229cb@gmail.com \
--to=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=urusov@granch.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).