* [PATCH] net: phy: ks8995: Fix bug while selecting sysfs node size
@ 2017-03-09 8:25 Lev Urusov
2017-03-10 0:10 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Lev Urusov @ 2017-03-09 8:25 UTC (permalink / raw)
To: netdev; +Cc: Lev Urusov, Florian Fainelli
From: Lev Urusov <urusov@granch.ru>
The driver will not be able to take into account the correct number
of device SPI registers if it is not equal to 128.
Signed-off-by: Lev Urusov <urusov@granch.ru>
---
drivers/net/phy/spi_ks8995.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index 93ffedf..f084725 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -491,8 +491,8 @@ static int ks8995_probe(struct spi_device *spi)
if (err)
return err;
- ks->regs_attr.size = ks->chip->regs_size;
memcpy(&ks->regs_attr, &ks8995_registers_attr, sizeof(ks->regs_attr));
+ ks->regs_attr.size = ks->chip->regs_size;
err = ks8995_reset(ks);
if (err)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: ks8995: Fix bug while selecting sysfs node size
2017-03-09 8:25 [PATCH] net: phy: ks8995: Fix bug while selecting sysfs node size Lev Urusov
@ 2017-03-10 0:10 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2017-03-10 0:10 UTC (permalink / raw)
To: Lev Urusov, netdev
On 03/09/2017 12:25 AM, Lev Urusov wrote:
> From: Lev Urusov <urusov@granch.ru>
>
> The driver will not be able to take into account the correct number
> of device SPI registers if it is not equal to 128.
>
> Signed-off-by: Lev Urusov <urusov@granch.ru>
Well, seems like someone already fixed that:
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=239870f2a0ebf75cc8f6d987dc528c5243f93d69
> ---
> drivers/net/phy/spi_ks8995.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
> index 93ffedf..f084725 100644
> --- a/drivers/net/phy/spi_ks8995.c
> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -491,8 +491,8 @@ static int ks8995_probe(struct spi_device *spi)
> if (err)
> return err;
>
> - ks->regs_attr.size = ks->chip->regs_size;
> memcpy(&ks->regs_attr, &ks8995_registers_attr, sizeof(ks->regs_attr));
> + ks->regs_attr.size = ks->chip->regs_size;
>
> err = ks8995_reset(ks);
> if (err)
>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-10 0:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-09 8:25 [PATCH] net: phy: ks8995: Fix bug while selecting sysfs node size Lev Urusov
2017-03-10 0:10 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).