From: Andrew Lunn <andrew@lunn.ch>
To: Kyle Switch <kyle.switch@motor-comm.com>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mmyangfl@gmail.com,
horms@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com
Subject: Re: [PATCH net-next v4] net: dsa: yt921x: Optimize driver for better generality.
Date: Wed, 2 Sep 2026 14:29:53 +0200 [thread overview]
Message-ID: <b91e38ca-7ef6-44c6-89c0-79419cba57f3@lunn.ch> (raw)
In-Reply-To: <20260902024737.587386-1-kyle.switch@motor-comm.com>
On Wed, Sep 02, 2026 at 10:47:37AM +0800, Kyle Switch wrote:
> Replace fixed macros with values defined in series_info
> for port validity checks, in order to facilitate future
> adaptation to more switch series.
>
> Replace all fixed values for DSA switch attributes with
> values defined in series_info, to enable better scalability
> across different switch families.
>
> Signed-off-by: Kyle Switch <kyle.switch@motor-comm.com>
> ---
>
> v4:
> 1. Split patch into multiple patches
I still only see one patch. I was expecting to see a patch series of 5
to 10 patches.
This one patch still does multiple things. It needs splitting up.
Please subscribe to the netdev list. Spend 15 minutes every day
looking at other developers patches. Look at how they split up
changes. Read the review comments. Follow a patch series from v1
through to vX until it is merged. If you see review comments which
apply to your code, please fix up your own code.
You can learn a lot this way, it is worth the time and effort.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-09-02 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 2:47 [PATCH net-next v4] net: dsa: yt921x: Optimize driver for better generality Kyle Switch
2026-09-02 12:29 ` Andrew Lunn [this message]
2026-09-04 9:34 ` Kyle Switch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b91e38ca-7ef6-44c6-89c0-79419cba57f3@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianmin.wang@motor-comm.com \
--cc=kuba@kernel.org \
--cc=kyle.switch@motor-comm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox