From: Vincent Bernat <vincent@bernat.ch>
To: "Maciej Żenczykowski" <maze@google.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Linux NetDev <netdev@vger.kernel.org>,
Pengtao He <hepengtao@xiaomi.com>,
Willem Bruijn <willemb@google.com>,
Stanislav Fomichev <sdf@google.com>, Xiao Ma <xiaom@google.com>,
Patrick Rohr <prohr@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Dave Tucker <datucker@redhat.com>,
Marek Majkowski <marek@cloudflare.com>
Subject: Re: Performance question: af_packet with bpf filter vs TX path skb_clone
Date: Sat, 5 Aug 2023 10:54:52 +0200 [thread overview]
Message-ID: <b9336a67-c337-ae86-2604-81368dcdfbac@bernat.ch> (raw)
In-Reply-To: <CANP3RGcTAjkPsFgqyeW5Tp9EJT-SrBX2CGVB7Zavkt6sKRKUOg@mail.gmail.com>
On 2023-08-03 10:46, Maciej Żenczykowski wrote:
> I think a fair number of these can get by with non-ETH_P_ALL (for
> example ETH_P_LLDP), or can use a different socket for RX (where you can
> choose to not see your own TX packets) and transmit via ETH_P_NONE (btw.
> that constant should really exist and be equal to 0)
Hey!
For lldpd, I was using ETH_P_LLDP in the past, but there was cases where
packets are not received, notably when an interface is enslaved by an
Open vSwitch. See:
https://github.com/lldpd/lldpd/commit/8b50be7f61ad20ebae15372a509f7e778da2cc6f
This may have been fixed, but this kind of differences between ETH_P_ALL
and ETH_P_LLDP makes it difficult to trust ETH_P_LLDP to do the right
thing as it will work for most people but a few edge cases may appear.
next prev parent reply other threads:[~2023-08-05 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 17:55 Performance question: af_packet with bpf filter vs TX path skb_clone Maciej Żenczykowski
2023-07-21 18:14 ` Eric Dumazet
2023-07-21 18:18 ` Stanislav Fomichev
2023-07-21 18:24 ` Eric Dumazet
2023-07-21 18:24 ` Maciej Żenczykowski
2023-07-21 18:56 ` Willem de Bruijn
2023-07-21 19:12 ` Maciej Żenczykowski
2023-08-02 14:30 ` Jesper Dangaard Brouer
2023-08-03 8:46 ` Maciej Żenczykowski
2023-08-05 8:54 ` Vincent Bernat [this message]
2023-08-05 10:09 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9336a67-c337-ae86-2604-81368dcdfbac@bernat.ch \
--to=vincent@bernat.ch \
--cc=ast@kernel.org \
--cc=datucker@redhat.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hepengtao@xiaomi.com \
--cc=marek@cloudflare.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=prohr@google.com \
--cc=sdf@google.com \
--cc=willemb@google.com \
--cc=xiaom@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox