From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDD8C388F9 for ; Wed, 11 Nov 2020 03:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB3ED20656 for ; Wed, 11 Nov 2020 03:41:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B8IH+OSY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725899AbgKKDl3 (ORCPT ); Tue, 10 Nov 2020 22:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbgKKDlO (ORCPT ); Tue, 10 Nov 2020 22:41:14 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86FE1C0613D1 for ; Tue, 10 Nov 2020 19:41:14 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id j5so267270plk.7 for ; Tue, 10 Nov 2020 19:41:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V60/pZ4LO23iVRxDRyDp4rYwAfm2SOQAQ8mQ4ry4Qf0=; b=B8IH+OSYtQQLP8GGQ6roddlwcg2/ryjnTKYxKLvAs1AdBntAEcnRywLnzobbVYlAuH mFiHaHPjVMv8DNmc5DpXI1al/cfzzL8XkzkYi9nRgQAPa3CcVblCDzLnL+3Ub6xuKSdV ioQ0M/yEOKFbtQNOeGqCkNpcdTalw6tDlQ+NXIqZqey9os13zDZ7oB4Zp/dHD+TtqLmU 5cd8xcJlbEnDMWKSkTsFu6gz2AN2yNXiY3Da9HKHKVUrs2oxl/rjcVrZKsCTYbtDYb3E l6m6mm8D98kvZl257KdbxX6Waod6IaWmLxW58OCanHr6uU53p3LFJF9IrivLi8JMTU84 472w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V60/pZ4LO23iVRxDRyDp4rYwAfm2SOQAQ8mQ4ry4Qf0=; b=YH0gEaABsrZFJDdfeCQQKVXkfkHXgoSf5A00rsi9HMgXAQzxw4pvT4wTWYnkndNFcV uoD9nNtLmBOhvOCIWZOlSGA5tLD+9xZ5Gx3FYaLwM3q811uZoB8cn6/BAM1MJpg4DNY8 pe53s/KclBG5dOwU5B1kzvITAWHba9qCQ7bgRMW6shqmh+csupkTQYH6ortRqHgR3W3S CSW1LC8FmsXvUryThcPn4lAiSfQSs8ZrS58y8SpT/1gVVf+/oK12PM+rExpt7o2uZD9N yuztsf+2VM4r67oaOqReAH6p35/ELMLS/ZhvL5AoICz9S3UCTtuY+Rp061iZRrUNXwtx FBMg== X-Gm-Message-State: AOAM530cksOPrgqdwtZN+VSq82wcLbw1pYHiHRIK16mFoPYUEXCE+zr8 qHhRpRIBa7jRlPkxhI+QnwXfq6hF3Qg= X-Google-Smtp-Source: ABdhPJzCNW3OpLB3t0nsJMB/hYVxRpGffQJCRO/cP0PI+j+lHk97dN1gwOezNaMi3hn7zkglSPi/GQ== X-Received: by 2002:a17:90b:2152:: with SMTP id kt18mr1745761pjb.10.1605066073651; Tue, 10 Nov 2020 19:41:13 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id j12sm570929pfd.203.2020.11.10.19.41.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 19:41:12 -0800 (PST) Subject: Re: [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers To: Tobias Waldekranz , davem@davemloft.net, kuba@kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org References: <20201110091325.21582-1-tobias@waldekranz.com> From: Florian Fainelli Message-ID: Date: Tue, 10 Nov 2020 19:41:11 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201110091325.21582-1-tobias@waldekranz.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/10/2020 1:13 AM, Tobias Waldekranz wrote: > Ethertype DSA encodes exactly the same information in the DSA tag as > the non-ethertype variety. So refactor out the common parts and reuse > them for both protocols. > > This is ensures tag parsing and generation as always consistent across > all mv88e6xxx chips. s/as/is/? This looks good to me! This made me remember that we do not really interface with devlink traps today in DSA, but we may be able to. -- Florian