From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ma Shimiao Subject: Re: [PATCH] drivers/staging/irda: fix max dup length for kstrndup Date: Wed, 13 Dec 2017 09:03:35 +0800 Message-ID: References: <20171212085444.15901-1-mashimiao.fnst@cn.fujitsu.com> <20171212102712.40e7a652@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , , To: Stephen Hemminger Return-path: Received: from mail.cn.fujitsu.com ([183.91.158.132]:7709 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752859AbdLMBCd (ORCPT ); Tue, 12 Dec 2017 20:02:33 -0500 In-Reply-To: <20171212102712.40e7a652@xeon-e3> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 12/13/2017 02:27 AM, Stephen Hemminger wrote: > On Tue, 12 Dec 2017 16:54:44 +0800 > Ma Shimiao wrote: > >> If source string longer than max, kstrndup will alloc max+1 space. >> So, we should make sure the result will not over limit. >> >> Signed-off-by: Ma Shimiao > > Did you read the TODO file in drivers/staging/irda? > > The irda code will be removed soon from the kernel tree as it is old and > obsolete and broken. > > Don't worry about fixing up anything here, it's not needed. Ah.. OK. Did not enter into the directory and notice it. > > > -- Ma Shimiao Development Dept.I Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)