From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
j.vosburgh@gmail.com, andy@greyhouse.net, dsahern@kernel.org,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
vinicius.gomes@intel.com, razor@blackwall.org,
idosch@nvidia.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] netlink: make range pointers in policies const
Date: Wed, 25 Oct 2023 18:23:30 +0200 [thread overview]
Message-ID: <b96201ae56ab165701fd5057bb9c52bb84369d91.camel@sipsolutions.net> (raw)
In-Reply-To: <20231025162204.132528-1-kuba@kernel.org>
On Wed, 2023-10-25 at 09:22 -0700, Jakub Kicinski wrote:
> struct nla_policy is usually constant itself, but unless
> we make the ranges inside constant we won't be able to
> make range structs const. The ranges are not modified
> by the core.
Makes sense, wonder why I didn't do that from the beginning ...
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2023-10-25 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 16:22 [PATCH net-next] netlink: make range pointers in policies const Jakub Kicinski
2023-10-25 16:23 ` Johannes Berg [this message]
2023-10-25 18:41 ` David Ahern
2023-10-25 19:12 ` Nikolay Aleksandrov
2023-10-26 5:44 ` Jiri Pirko
2023-10-26 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96201ae56ab165701fd5057bb9c52bb84369d91.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=j.vosburgh@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).