From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D216DC282C3 for ; Tue, 22 Jan 2019 22:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96BC6217F5 for ; Tue, 22 Jan 2019 22:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sOUftxq7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbfAVWx2 (ORCPT ); Tue, 22 Jan 2019 17:53:28 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37328 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfAVWx2 (ORCPT ); Tue, 22 Jan 2019 17:53:28 -0500 Received: by mail-pg1-f196.google.com with SMTP id c25so106202pgb.4 for ; Tue, 22 Jan 2019 14:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DwOA3KT7PXEpuVdSJp4VycVtTACYvkua0pZTT4mUNZU=; b=sOUftxq79K0FUdPqHk634BQB2+F7ss+rEpR/gitvqqUTJHAHrVVn9WEyr0O2dCPdLH 8k4TNAxe5bqNG5D+vwtF2P/eF0NBj3Uh6AOPnyMe1esITjtz55k5agOIx99pRAr3nLlw ihi/lghg1fzw3RA426MpNmo5bgmRQWZPxlcvnwZzYIe9TndoyfnMHQjNdFQiW0hwmGQf p15fR2AtG9JzZL2tzk3FBUt9MokOnsKNXqvUPhWflrn5OXHuf9TqQ4IKVvUv3RhePNER Lte5fcjd9Fcgs626gK3679cBsZwPUiymd82BwGjThLJzJRyqRNaeW/PTQATjsJzpVIfk 911Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DwOA3KT7PXEpuVdSJp4VycVtTACYvkua0pZTT4mUNZU=; b=ax3X4g8bwfTSH3oscAYZpDU/d4W/XDa3vLTyqux4J8IYgC0lMbbt/LwMPM44WZiRl6 yVuQtj8l5LXEUk+6qdTz4P6Y6Raqgis/ac3XKD/ASnr1w7lF4bQ90c+9E6nVgVLb+Z1M FsJFAicboYE9yuxjTRlnymHjOSWKoZtj0WPEsUoNrMd/9HAMe7k7Z3D9dPNBBmhCBmuE 9nbemTYK6IiD5h/MiHisx5bUY+2MRBAkivswICLRB2jv9w8N41mML9QMVHvjoZckt5GM fS6q1/2y7z8zpXRtIudl7g3aXOl0NKvjbby8D0oExkn5IocAJnIf7VHkorOcynCZeFBK 1UbA== X-Gm-Message-State: AJcUukfibLOxHZxoQMzFdHrieygSIk8WFdgDrXEIKSSFls+OWC/EAk/8 qOwxYsjpQNr7W9ZBSFh1+qHeKC8y X-Google-Smtp-Source: ALg8bN40SZHJlXhzaahEhOlV1if88dxUJeVc7LPKq1Z1/e958O4lUis87Jeh/45PQy1lzlRC7JaNeg== X-Received: by 2002:a63:2905:: with SMTP id p5mr34039511pgp.178.1548197607410; Tue, 22 Jan 2019 14:53:27 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:1169:5cd2:eb20:96a2? ([2601:282:800:fd80:1169:5cd2:eb20:96a2]) by smtp.googlemail.com with ESMTPSA id h79sm26361090pfj.186.2019.01.22.14.53.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 14:53:26 -0800 (PST) Subject: Re: [PATCH net v2] net/ipv6: don't return positive numbers when nothing was dumped To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com References: <20190122224719.7509-1-jakub.kicinski@netronome.com> From: David Ahern Message-ID: Date: Tue, 22 Jan 2019 15:53:25 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190122224719.7509-1-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/22/19 3:47 PM, Jakub Kicinski wrote: > in6_dump_addrs() returns a positive 1 if there was nothing to dump. > This return value can not be passed as return from inet6_dump_addr() > as is, because it will confuse rtnetlink, resulting in NLMSG_DONE > never getting set: > > $ ip addr list dev lo > EOF on netlink > Dump terminated > > v2: flip condition to avoid a new goto (DaveA) > > Fixes: 7c1e8a3817c5 ("netlink: fixup regression in RTM_GETADDR") > Reported-by: Brendan Galloway > Signed-off-by: Jakub Kicinski > --- > net/ipv6/addrconf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 57198b3c86da..015e5ccbe306 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -5155,6 +5155,8 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb, > if (idev) { > err = in6_dump_addrs(idev, skb, cb, s_ip_idx, > &fillargs); > + if (err > 0) > + err = 0; > } > goto put_tgt_net; > } > Reviewed-by: David Ahern Tested-by: David Ahern Thanks, Jakub.