From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool Date: Fri, 5 Aug 2016 14:40:53 +0300 Message-ID: References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-9-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Julia Lawall Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 8/5/2016 2:38 PM, Julia Lawall wrote: >>> Use of_property_read_bool to check for the existence of a property. >>> >>> The semantic patch that makes this change is as follows: >>> (http://coccinelle.lip6.fr/) >>> >>> // >>> @@ >>> expression e1,e2; >>> statement S2,S1; >>> @@ >>> - if (of_get_property(e1,e2,NULL)) >>> + if (of_property_read_bool(e1,e2)) >>> S1 else S2 >>> // >>> >>> Signed-off-by: Julia Lawall >>> >>> --- >>> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c >>> b/drivers/net/ethernet/freescale/xgmac_mdio.c >>> index 7b8fe86..a77ba98 100644 >>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c >>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c >>> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device >>> *pdev) >>> goto err_ioremap; >>> } >>> >>> - if (of_get_property(pdev->dev.of_node, >>> - "little-endian", NULL)) >>> + if (of_property_read_bool(pdev->dev.of_node, "little-endian")) >>> priv->is_little_endian = true; >>> else >>> priv->is_little_endian = false; >> >> priv->is_little_endian = of_property_read_bool(pdev->dev.of_node, >> "little-endian")); > > Thanks, > > I just sent a v2 with this change. I've seen. Sorry, forgot to look at the followups before commenting... > julia MBR, Sergei