* [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state
@ 2017-06-19 16:27 John Allen
2017-06-20 17:36 ` Nathan Fontenot
2017-06-20 19:17 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: John Allen @ 2017-06-19 16:27 UTC (permalink / raw)
To: netdev; +Cc: Nathan Fontenot, Thomas Falcon
If the ibmvnic driver is not in the VNIC_OPEN state, return from
ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts
may not be initialized and directly calling the interrupt handler will
cause a crash.
Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
---
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 722daf5..0135095 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3859,6 +3859,9 @@ static int ibmvnic_resume(struct device *dev)
struct ibmvnic_adapter *adapter = netdev_priv(netdev);
int i;
+ if (adapter->state != VNIC_OPEN)
+ return 0;
+
/* kick the interrupt handlers just in case we lost an interrupt */
for (i = 0; i < adapter->req_rx_queues; i++)
ibmvnic_interrupt_rx(adapter->rx_scrq[i]->irq,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state
2017-06-19 16:27 [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state John Allen
@ 2017-06-20 17:36 ` Nathan Fontenot
2017-06-20 19:17 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Fontenot @ 2017-06-20 17:36 UTC (permalink / raw)
To: John Allen, netdev; +Cc: Thomas Falcon
On 06/19/2017 11:27 AM, John Allen wrote:
> If the ibmvnic driver is not in the VNIC_OPEN state, return from
> ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts
> may not be initialized and directly calling the interrupt handler will
> cause a crash.
>
> Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> ---
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 722daf5..0135095 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -3859,6 +3859,9 @@ static int ibmvnic_resume(struct device *dev)
> struct ibmvnic_adapter *adapter = netdev_priv(netdev);
> int i;
>
> + if (adapter->state != VNIC_OPEN)
> + return 0;
> +
> /* kick the interrupt handlers just in case we lost an interrupt */
> for (i = 0; i < adapter->req_rx_queues; i++)
> ibmvnic_interrupt_rx(adapter->rx_scrq[i]->irq,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state
2017-06-19 16:27 [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state John Allen
2017-06-20 17:36 ` Nathan Fontenot
@ 2017-06-20 19:17 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-20 19:17 UTC (permalink / raw)
To: jallen; +Cc: netdev, nfont, tlfalcon
From: John Allen <jallen@linux.vnet.ibm.com>
Date: Mon, 19 Jun 2017 11:27:53 -0500
> If the ibmvnic driver is not in the VNIC_OPEN state, return from
> ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts
> may not be initialized and directly calling the interrupt handler will
> cause a crash.
>
> Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 19:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 16:27 [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state John Allen
2017-06-20 17:36 ` Nathan Fontenot
2017-06-20 19:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).