From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952B5C4727E for ; Thu, 1 Oct 2020 20:55:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55FAC20738 for ; Thu, 1 Oct 2020 20:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730045AbgJAUzM (ORCPT ); Thu, 1 Oct 2020 16:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgJAUzM (ORCPT ); Thu, 1 Oct 2020 16:55:12 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10596C0613D0 for ; Thu, 1 Oct 2020 13:55:12 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kO5ba-00EodC-3N; Thu, 01 Oct 2020 22:55:10 +0200 Message-ID: Subject: Re: [PATCH net-next 8/9] genetlink: use per-op policy for CTRL_CMD_GETPOLICY From: Johannes Berg To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us, mkubecek@suse.cz, dsahern@kernel.org, pablo@netfilter.org Date: Thu, 01 Oct 2020 22:55:09 +0200 In-Reply-To: <20201001183016.1259870-9-kuba@kernel.org> References: <20201001183016.1259870-1-kuba@kernel.org> <20201001183016.1259870-9-kuba@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2020-10-01 at 11:30 -0700, Jakub Kicinski wrote: > Wire up per-op policy for CTRL_CMD_GETPOLICY. > This saves us a call to genlmsg_parse() and will soon allow > dumping this policy. Hmm. Probably should've asked this before - I think the code makes perfect sense, but I'm not sure how "this" follows? I mean, we could've saved the genlmsg_parse() call before, with much the same patch, having the per-op policy doesn't really have any bearing for that? It was just using a different policy - the family one - instead of the per-op one, but ... Am I missing something? johannes