From mboxrd@z Thu Jan 1 00:00:00 1970 From: YueHaibing Subject: Re: [PATCH] connector: hide unused procfs helpers Date: Fri, 13 Jul 2018 17:31:21 +0800 Message-ID: References: <20180713071141.15996-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: , To: Return-path: In-Reply-To: <20180713071141.15996-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org pls ignore this,my bad. On 2018/7/13 15:11, YueHaibing wrote: > When CONFIG_PROC_FS isn't set, gcc warning this: > > drivers/connector/connector.c:242:12: warning: ‘cn_proc_show’ defined but not used [-Wunused-function] > static int cn_proc_show(struct seq_file *m, void *v) > ^ > fix this by adding #ifdef around it. > > Signed-off-by: YueHaibing > --- > drivers/connector/connector.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c > index e718b8c..e2636d4 100644 > --- a/drivers/connector/connector.c > +++ b/drivers/connector/connector.c > @@ -239,6 +239,7 @@ void cn_del_callback(struct cb_id *id) > } > EXPORT_SYMBOL_GPL(cn_del_callback); > > +#ifdef CONFIG_PROC_FS > static int cn_proc_show(struct seq_file *m, void *v) > { > struct cn_queue_dev *dev = cdev.cbdev; > @@ -259,6 +260,7 @@ static int cn_proc_show(struct seq_file *m, void *v) > > return 0; > } > +#endif > > static struct cn_dev cdev = { > .input = cn_rx_skb, >