From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53228C433F5 for ; Fri, 15 Apr 2022 02:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348738AbiDOCjv (ORCPT ); Thu, 14 Apr 2022 22:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240097AbiDOCjs (ORCPT ); Thu, 14 Apr 2022 22:39:48 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE8C94BB9B; Thu, 14 Apr 2022 19:37:21 -0700 (PDT) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KfgRN509VzQj6r; Fri, 15 Apr 2022 10:35:28 +0800 (CST) Received: from [10.174.176.117] (10.174.176.117) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 10:37:18 +0800 Subject: Re: [PATCH bpf-next v2 0/6] bpf trampoline for arm64 To: Xu Kuohai , , , , , CC: Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , , , Shuah Khan , Mark Rutland , Ard Biesheuvel , Pasha Tatashin , Peter Collingbourne , Daniel Kiss , Sudeep Holla , Steven Price , Marc Zyngier , Mark Brown , Kumar Kartikeya Dwivedi , Delyan Kratunov References: <20220414162220.1985095-1-xukuohai@huawei.com> From: Hou Tao Message-ID: Date: Fri, 15 Apr 2022 10:37:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220414162220.1985095-1-xukuohai@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.176.117] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500025.china.huawei.com (7.185.36.35) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 4/15/2022 12:22 AM, Xu Kuohai wrote: > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > Tested on qemu, result: > #55 fentry_fexit:OK > #56 fentry_test:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #101 modify_return:OK bpf_struct_ops also depends on bpf trampoline, could you please also add the test results for bpf_struct_ops related tests case ? > > v2: > - Add Song's ACK > - Change the multi-line comment in is_valid_bpf_tramp_flags() into net > style (patch 3) > - Fix a deadloop issue in ftrace selftest (patch 2) > - Replace pt_regs->x0 with pt_regs->orig_x0 in patch 1 commit message > - Replace "bpf trampoline" with "custom trampoline" in patch 1, as > ftrace direct call is not only used by bpf trampoline. > > v1: https://lore.kernel.org/bpf/20220413054959.1053668-1-xukuohai@huawei.com/ > > Xu Kuohai (6): > arm64: ftrace: Add ftrace direct call support > ftrace: Fix deadloop caused by direct call in ftrace selftest > bpf: Move is_valid_bpf_tramp_flags() to the public trampoline code > bpf, arm64: Impelment bpf_arch_text_poke() for arm64 > bpf, arm64: bpf trampoline for arm64 > selftests/bpf: Fix trivial typo in fentry_fexit.c > > arch/arm64/Kconfig | 2 + > arch/arm64/include/asm/ftrace.h | 10 + > arch/arm64/kernel/asm-offsets.c | 1 + > arch/arm64/kernel/entry-ftrace.S | 28 +- > arch/arm64/net/bpf_jit.h | 14 +- > arch/arm64/net/bpf_jit_comp.c | 390 +++++++++++++++++- > arch/x86/net/bpf_jit_comp.c | 20 - > include/linux/bpf.h | 5 + > kernel/bpf/bpf_struct_ops.c | 4 +- > kernel/bpf/trampoline.c | 35 +- > kernel/trace/trace_selftest.c | 4 +- > .../selftests/bpf/prog_tests/fentry_fexit.c | 4 +- > 12 files changed, 482 insertions(+), 35 deletions(-) >