From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from baidu.com (mx24.baidu.com [111.206.215.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9BA158206 for ; Fri, 21 Jun 2024 06:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=111.206.215.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718950906; cv=none; b=NXMRgtSIwUv7XVOHCgHS5MXyvcez+vIozUC2ibZDVRzK7c49p9KNli+8k5qN8UrYoRGg2J530cJCuoS3oO5CTW1EuGocHXUZ3VEmewDn3Z1d1MAYYLdYlC2Yno7xW9ZHKKb5X3+wwi1iB+fNIrhD7m34tQQ2mGQZfm017q8vFP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718950906; c=relaxed/simple; bh=u57FyeN4yXEi543jN5gw5XXDtHFLHwnOdJ8bk5RideY=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=qV3tVCmRFvDVEGJgHf+FtgKRMpzCybwdcHYMaSCZ9J6MluTdCHBCnGLbjynjAa2qscGFkEX7eq9ASLE9mzLALMheDQANfZYLRdjXqY5BJvKrZJAfezhrICFA+8nL3xSCyHtr5WgCSgwqwDweOH14JETmI3IiXaZUmtbw6Fm9zBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com; spf=pass smtp.mailfrom=baidu.com; arc=none smtp.client-ip=111.206.215.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baidu.com From: "Li,Rongqing" To: Jakub Kicinski CC: "mst@redhat.com" , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "eperezma@redhat.com" , "hengqi@linux.alibaba.com" , "virtualization@lists.linux.dev" , "netdev@vger.kernel.org" Subject: RE: [????] Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch Thread-Topic: [????] Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for stats fetch Thread-Index: AQHawfQooceI1YM1lUOLDiZ4kyQEFrHQLNAAgAGUPLA= Date: Fri, 21 Jun 2024 06:20:45 +0000 Message-ID: References: <20240619025529.5264-1-lirongqing@baidu.com> <20240620070908.2efe2048@kernel.org> In-Reply-To: <20240620070908.2efe2048@kernel.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-FEAS-Client-IP: 172.31.51.56 X-FE-Last-Public-Client-IP: 100.100.100.38 X-FE-Policy-ID: 52:10:53:SYSTEM > Did you by any chance use an automated tool of any sort to find this issu= e or > generate the fix? >=20 > I don't think this is actually necessary here, you're in the same context= as the > updater of the stats, you don't need any protection. > You can remove u64_stats_update_begin() / end() (in net-next, there's no = bug). >=20 > I won't comment on implications of calling dim_update_sample() in a loop. >=20 > Please make sure you answer my "did you use a tool" question, I'm really > curious. I have no tool, I find this when I investigating a DIM related issue. Thanks