From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"horms@kernel.org" <horms@kernel.org>,
Ping-Ke Shih <pkshih@realtek.com>,
Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v3] rtase: Add ndo_setup_tc support for CBS offload in traffic control setup
Date: Wed, 16 Apr 2025 07:04:09 +0000 [thread overview]
Message-ID: <b9fcab27bc6a4d35ba32438623e5b259@realtek.com> (raw)
In-Reply-To: <20250415172303.19022025@kernel.org>
>
> On Mon, 14 Apr 2025 11:42:02 +0800 Justin Lai wrote:
> > Add support for ndo_setup_tc to enable CBS offload functionality as
> > part of traffic control configuration for network devices.
>
> This is some semi-switch-like device right? Or am I misremembering?
> Could you clarify where the limits are applied?
> From CPU into the switch or on the switch ports?
> Should be documented in the commit msg.
> --
> pw-bot: cr
Hi Jakub,
Yes, this device is a switch, and CBS is applied from the CPU to the
switch. More specifically, CBS is applied at the GMAC in the topmost
architecture diagram in this driver. I will post a new version and
add this information to the commit message.
Thanks,
Justin
prev parent reply other threads:[~2025-04-16 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 3:42 [PATCH net-next v3] rtase: Add ndo_setup_tc support for CBS offload in traffic control setup Justin Lai
2025-04-15 18:17 ` Simon Horman
2025-04-16 0:23 ` Jakub Kicinski
2025-04-16 7:04 ` Justin Lai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9fcab27bc6a4d35ba32438623e5b259@realtek.com \
--to=justinlai0215@realtek.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).