Re: [PATCH 1/2] Add an alternative cs89x0 driver

[Ivo Clarysse <ivo.clarysse@gmail.com>]

On Wed, Apr 22, 2009 at 9:59 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:

> +#define CS8900A                        0x0000
> +#define REV_B                  7
> +#define REV_C                  8
> +#define REV_D                  9

These REV_B / REV_C / REV_D defines are not used, and in fact depend
on the cs89x0x variant.

> +       dev_info(&pdev->dev, "CS8900A rev %c detected\n",
> +                       'B' + REVISION(value) - REV_B);

This will report incorrectly for CS8900 (not CS8900A),  and for CS8900A rev. F:

According to the CS8900A and CS8920A datasheets, the product ID should
be interpreted as:

0x0700  CS8900A rev. B
0x0800  CS8900A rev. C
0x0900  CS8900A rev. D
0x0A00  CS8900A rev. F
0x6100  CS8920 rev. B
0x6200  CS8920 rev. C
0x6300  CS8920 rev. D
0x6400  CS8920A rev. A/B
0x6500  CS8920A rev. C

(I couldn't find the datasheet for the original CS8900; acoording to
http://www.cirrus.com/en/products/eol/index.html, the CS8900A is the
only CS89X0X variant which is not EOL)


Ivo.