public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "olteanv@gmail.com" <olteanv@gmail.com>,
	"andrew@lunn.ch" <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: honor "max-speed" for implicit PHYs on user ports
Date: Fri, 20 Dec 2024 07:30:54 +0000	[thread overview]
Message-ID: <ba41f79205ff4c0c90de71a6be2dd4e2e9ade0f7.camel@siemens.com> (raw)
In-Reply-To: <b708216ed804755678f01f62b286928763a1f645.camel@siemens.com>

Hi Vladimir!

On Fri, 2024-12-20 at 08:17 +0100, Alexander Sverdlin wrote:
> > On Thu, Dec 19, 2024 at 06:50:18PM +0000, Sverdlin, Alexander wrote:
> > > There are still switch drivers in tree, which only implement .phy_read/.phy_write
> > > callbacks (which means, they rely on .user_mii_bus ?), even gigabit-capable,
> > > such as vsc73xx, rtl8365mb, rtl8366rb... But I'm actually interested in an
> > > out of tree driver for a new generation of lantiq_gsw hardware, under
> > > Maxlinear branch, which is planned to be submitted upstream at some point.
> > > 
> > > The relevant question is then, is it acceptable API (.phy_read/.phy_write),
> > > or any new gigabit-capable driver must use some form of mdiobus_register
> > > to populate the MDIO bus explicitly itself?
> > 
> > See the documentation patches which I never managed to finish for general
> > future directions:
> > https://patchwork.kernel.org/project/netdevbpf/patch/20231208193518.2018114-4-vladimir.oltean@nxp.com/
> > 
> > Not explicitly having a phy-handle should be seen a legacy feature,
> > which we are forced to keep for compatibility with existing drivers.
> 
> Thanks for the references!
> 
> I've complitely missed the story of
> fe7324b93222 ("net: dsa: OF-ware slave_mii_bus")
> vs ae94dc25fd73
> ("net: dsa: remove OF-based MDIO bus registration from DSA core").
> 
> But I'm still having hard time to get the motivation behind removing
> 2 function calls from the DSA core and forcing all individual DSA drivers
> to have this very same boilerplate...
> 
> But well, if all the DSA maintainers are so committed to it, this answers
> my original question... Please ignore the patch!

However, after reading the whole referenced thread, I still have a question:
will MFD approach (with both drivers and dt-bindings) will be a requirement
for any new drivers or a simpler approach with "mdio {}" node under the
switch node will still be acceptable?

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

  reply	other threads:[~2024-12-20  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 17:38 [PATCH net-next] net: dsa: honor "max-speed" for implicit PHYs on user ports A. Sverdlin
2024-12-19 17:46 ` Vladimir Oltean
2024-12-19 18:50   ` Sverdlin, Alexander
2024-12-19 19:36     ` Vladimir Oltean
2024-12-20  7:17       ` Sverdlin, Alexander
2024-12-20  7:30         ` Sverdlin, Alexander [this message]
2024-12-20  8:28           ` Andrew Lunn
2024-12-20 10:15         ` Vladimir Oltean
2024-12-19 17:46 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba41f79205ff4c0c90de71a6be2dd4e2e9ade0f7.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=andrew@lunn.ch \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox