From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7E8C282C4 for ; Mon, 4 Feb 2019 11:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A7162082F for ; Mon, 4 Feb 2019 11:55:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ncentric-com.20150623.gappssmtp.com header.i=@ncentric-com.20150623.gappssmtp.com header.b="M+z+VD8W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728480AbfBDLzg (ORCPT ); Mon, 4 Feb 2019 06:55:36 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:39396 "EHLO mail-ed1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727555AbfBDLzg (ORCPT ); Mon, 4 Feb 2019 06:55:36 -0500 Received: by mail-ed1-f46.google.com with SMTP id b14so10980586edt.6 for ; Mon, 04 Feb 2019 03:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncentric-com.20150623.gappssmtp.com; s=20150623; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=RpARSPfeatCkxQjq3myWqEdxIUwrjF0tHhxW0+PzkdU=; b=M+z+VD8Wp72UrsvKOlZBpjzTV2zgtiqjvwglG0dF1m0ub6NIXJH9XgpOianELmb6hC 5nTKnPbRisqllUK9a+HdoOb4dt6y99HnI10qktzIPyggiV/6TxFpRTvkDyM61Owo+Qk1 NiCJlt2dioCHeJYnL6juz2NcokA81LHuri7mD0UU33jvYu5Y5/URz6Pki+lCnp4R2HfG Ony2e3Mg/wqdW84uzCj6Kg0MPi3N/5WZWrJr1YX3RaP3s5qSxazVpBlbbFFen4DSC5wI W5/BPrwOKSGRNPiUEJBskksn5WJnUAWWcTnM4P/yuZAUrI624WCbdeFgnXnJ16F1r0UI JjEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=RpARSPfeatCkxQjq3myWqEdxIUwrjF0tHhxW0+PzkdU=; b=FtJeyMUDte5XalMbUEDI2y0Dls7YtH8FEgtFxJgBhLVGbpddh62qdjtg29lhcnJpgj 15XixORgLsRWmeqUT2NE+7f9KS/QPoAvjr9Z5uvVe34fgGHkU1LFr0ayNppaZ4D7Egci YL44RnwRP4DYUH7rw5GyeLwn9ogFfShWScGxXrjxBuMrQjrpF+CoPGcirbTAIV8Z/l/b uy9N1zuJ+wvIu4Dor1kwtBVxpXI8Et9i4RJqWkyhWpgA2hnggLb2BV+TtfyqUPXzwp0J evXccYp4lV9cPwfc1tSaWmnpnB8rCOg2KMLEC1SDGaBGhxAmQ6elFX+QW840adLIui/U nacA== X-Gm-Message-State: AJcUukdpB8k/+HKvAmYs7tXHfWMj5OqC6TF+8/e7Xn5j4PiW5Lmm71dT oQTnsxbsJKIeEYaxcTjfiH/3QmhpEeY= X-Google-Smtp-Source: ALg8bN6xMjocDfWU2k56Nk92bnE8PUvLbzaoEbRHoBWrH0g40micboY1IuWxldZ6y3kvZgKh8oPmBg== X-Received: by 2002:a50:ca86:: with SMTP id x6mr48912503edh.287.1549281334369; Mon, 04 Feb 2019 03:55:34 -0800 (PST) Received: from [192.168.3.176] (d515300d8.static.telenet.be. [81.83.0.216]) by smtp.gmail.com with ESMTPSA id v11sm4097472edy.49.2019.02.04.03.55.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 03:55:33 -0800 (PST) To: netdev@vger.kernel.org From: Koen Vandeputte Subject: Compiler warning - ipv4 fib_trie Message-ID: Date: Mon, 4 Feb 2019 12:55:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi All, During compilation of kernel 4.14.96 and 5.0-rc5 I'm seeing following warning: net/ipv4/fib_trie.c: In function 'fib_trie_unmerge': net/ipv4/fib_trie.c:1749:8: warning: 'local_tp' may be used uninitialized in this function [-Wmaybe-uninitialized]     if (fib_insert_alias(lt, local_tp, local_l, new_fa,         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~            NULL, l->key)) {            ~~~~~~~~~~~~~ Code: https://elixir.bootlin.com/linux/v5.0-rc5/source/net/ipv4/fib_trie.c#L1731 Looks like 'local_tp' should be NULL-ified Thanks, Koen