From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next ] net: mscc: Add SPDX identifier Date: Thu, 17 May 2018 18:13:25 -0700 Message-ID: References: <20180517192305.17517-1-alexandre.belloni@bootlin.com> <53ccb8c58e4c3e224ba694c0628096d0c041ba1a.camel@perches.com> <20180517193900.GE6828@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Allan Nielsen , razvan.stefanescu@nxp.com, po.liu@nxp.com, Thomas Petazzoni , Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Alexandre Belloni Return-path: In-Reply-To: <20180517193900.GE6828@piout.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > > > ocelot_qsys.h is missing the SPDX identfier, fix that. > > > > > > Signed-off-by: Alexandre Belloni > > > > Only the copyright holders should ideally be modifying > > these and also removing other license content. > > > > For instance, what's the real intent here? > > > > Well, if you have a look, I submitted that file this cycle and it is the > only one that doesn't have the proper SPDX identifier. This is a mistake > I'm fixing. Just because you submitted it does not mean you are the copyright holder. > > > diff --git a/drivers/net/ethernet/mscc/ocelot_qsys.h b/drivers/net/ethernet/mscc/ocelot_qsys.h > > > > [] > > > @@ -1,7 +1,7 @@ > > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > > > > GPL 2.0+ or 2.0? > > > > 2.0 How do you know that?