From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bader Subject: Re: [PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean Date: Thu, 23 Aug 2018 09:07:24 +0200 Message-ID: References: <20180822180903.26443-1-bluca@debian.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Abqqlsp32qugRWrJAvm2uF1CAjVPlmBHI" Cc: stephen@networkplumber.org To: Luca Boccassi , netdev@vger.kernel.org Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:52380 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbeHWKfq (ORCPT ); Thu, 23 Aug 2018 06:35:46 -0400 In-Reply-To: <20180822180903.26443-1-bluca@debian.org> Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Abqqlsp32qugRWrJAvm2uF1CAjVPlmBHI Content-Type: multipart/mixed; boundary="pUIWryMgzE5KvhdTGqZycX4jna9qEaTPS"; protected-headers="v1" From: Stefan Bader To: Luca Boccassi , netdev@vger.kernel.org Cc: stephen@networkplumber.org Message-ID: Subject: Re: [PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean References: <20180822180903.26443-1-bluca@debian.org> In-Reply-To: <20180822180903.26443-1-bluca@debian.org> --pUIWryMgzE5KvhdTGqZycX4jna9qEaTPS Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 22.08.2018 20:09, Luca Boccassi wrote: > Some generated test files were not removed, including one executable in= > the testsuite/tools directory. > Ensure make clean from the top level directory works for the testsuite > subdirs too, and that all the files are removed. >=20 > Signed-off-by: Luca Boccassi > --- Patch 1+2 look good to me and I would ack if that would count in any way.= For patch 3 I only wonder whether that might re-use $PREFIX (which is defined as "sudo -E unshare -n"). Ok, the unshare part might be slight overkill, but maybe a little better in style. Not sure though, and it is high level whining... -Stefan > Makefile | 2 +- > testsuite/Makefile | 3 +++ > testsuite/tools/Makefile | 3 +++ > 3 files changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/Makefile b/Makefile > index 651d2a50..ea2f797c 100644 > --- a/Makefile > +++ b/Makefile > @@ -96,7 +96,7 @@ snapshot: > > include/SNAPSHOT.h > =20 > clean: > - @for i in $(SUBDIRS); \ > + @for i in $(SUBDIRS) testsuite; \ > do $(MAKE) $(MFLAGS) -C $$i clean; done > =20 > clobber: > diff --git a/testsuite/Makefile b/testsuite/Makefile > index 8fcbc557..2acd0427 100644 > --- a/testsuite/Makefile > +++ b/testsuite/Makefile > @@ -43,6 +43,9 @@ alltests: $(TESTS) > clean: > @echo "Removing $(RESULTS_DIR) dir ..." > @rm -rf $(RESULTS_DIR) > + @rm -f iproute2/iproute2-this > + @rm -f tests/ip/link/dev_wo_vf_rate.nl > + $(MAKE) -C tools clean > =20 > distclean: clean > echo "Entering iproute2" && cd iproute2 && $(MAKE) distclean && cd ..= ; > diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile > index f2cdc980..f0ce4ee2 100644 > --- a/testsuite/tools/Makefile > +++ b/testsuite/tools/Makefile > @@ -1,3 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > generate_nlmsg: generate_nlmsg.c ../../lib/libnetlink.c > $(CC) -o $@ $^ > + > +clean: > + rm -f generate_nlmsg >=20 --pUIWryMgzE5KvhdTGqZycX4jna9qEaTPS-- --Abqqlsp32qugRWrJAvm2uF1CAjVPlmBHI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJbfl0zAAoJEOhnXe7L7s6jv3IP/3x1exXlBn2Bv35d67LaEMB3 PJL5VG5IIgOhZz8mdYdn2m/VO2nSEs+yyWnf0qBx1Z4K/FApzy2kaGJ69/DzXy6+ n8iigs+iYIqeS7hiWEcTtyg4A+3sAk+U/n5gZAgWbagN9qN7TtZNjLxAbVFVinuj OjMK0kwRYiFK7C2J565rVozR/TTkA61O5LYPjpsfWdqyAZgp6EDZhWp47HKBZEyS M4DbVhzXLSfsobon+kiFZrDSVLYaA+2eZxUBflfWuXjxTME1jkOimipbOhoL8uBb Ju8wwacTakLtgaXLQF2u2vP1qWQ0JmeqNV+2rmdEV2B/9OPsci+QyvfSp79AHEHO TvW73BSFryj/MC/G13qU6VrRsWrXXOZx2b7Ar/kqLL3lwgmrbgwe+w9bXfUe9498 a6ShGICiCcAHxgBTUpQE8WOQiDfREA5Ny0u3XoFmpw7V0n9rDfc821g3L2BJgAIz bv0CsLMZ/q1/EJ6U7xnKINT7ct7BRIHSs7G1mpPpwKflvJay4ppqtfjle/uwN5+r tEdimdc8/5byyLhI1ksl1vXs9sCl+co0csgQxTQytetSx8C8ogZSbmdrt2aX6Dve YFBN8iuiGVmRB0y4Put6v0yW+tIsd1tqG1Y3AL97jNe6gMhU4wLZJbR/KPZTre3q ZSII13YiWWXf3v3wiaWT =OUZH -----END PGP SIGNATURE----- --Abqqlsp32qugRWrJAvm2uF1CAjVPlmBHI--