From: Jens Axboe <axboe@kernel.dk>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
Pavel Begunkov <asml.silence@gmail.com>,
Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Subject: Re: [PATCH net-next] net: reclaim skb->scm_io_uring bit
Date: Tue, 7 Mar 2023 08:24:59 -0700 [thread overview]
Message-ID: <bad4c222-de52-625e-e73d-5997a7553a57@kernel.dk> (raw)
In-Reply-To: <20230307145959.750210-1-edumazet@google.com>
On 3/7/23 7:59 AM, Eric Dumazet wrote:
> Commit 0091bfc81741 ("io_uring/af_unix: defer registered
> files gc to io_uring release") added one bit to struct sk_buff.
>
> This structure is critical for networking, and we try very hard
> to not add bloat on it, unless absolutely required.
Understandable.
> For instance, we can use a specific destructor as a wrapper
> around unix_destruct_scm(), to identify skbs that unix_gc()
> has to special case.
Looks fine to me:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2023-03-07 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 14:59 [PATCH net-next] net: reclaim skb->scm_io_uring bit Eric Dumazet
2023-03-07 15:24 ` Jens Axboe [this message]
2023-03-07 15:29 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bad4c222-de52-625e-e73d-5997a7553a57@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=cascardo@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).