From: Nimrod Oren <noren@nvidia.com>
To: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: "Saeed Mahameed" <saeedm@nvidia.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Mark Bloch" <mbloch@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Gal Pressman" <gal@nvidia.com>,
"Cosmin Ratiu" <cratiu@nvidia.com>,
"Dragos Tatulea" <dtatulea@nvidia.com>,
"Carolina Jubran" <cjubran@nvidia.com>,
"Björn Töpel" <bjorn@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net-next v4] net/mlx5e: advertise tcp-data-split support
Date: Sun, 15 Nov 2026 12:39:11 +0200 [thread overview]
Message-ID: <baf3a990-c9a7-4bf1-a1a7-a2b8976591bc@nvidia.com> (raw)
In-Reply-To: <20261111170558.1654691-1-dimitri.daskalakis1@gmail.com>
On 11/11/2026 19:05, Dimitri Daskalakis wrote:
> Changes in v4:
> - Nimrod and sashiko pointed out that not reporting DISABLED for
> tcp-data-split makes the feature look unsupported. This conflicted
> with my attempt to block users from setting DISABLED, locally sashiko
> found several scenarios where ring changes would get blocked.
Can you please share those scenarios?
I think blocking 'disabled' was the right direction. Allowing it doesn't
give users anything new, only a way to pin HW-GRO off, at the cost of
another dependency between the two knobs in mlx5e_fix_features().
We can still report 'disabled' when HW-GRO is supported but off.
next prev parent reply other threads:[~2026-11-15 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 17:05 [PATCH net-next v4] net/mlx5e: advertise tcp-data-split support Dimitri Daskalakis
2026-11-13 8:06 ` netdev-bot+sashiko
2026-11-13 17:59 ` Dimitri Daskalakis
2026-11-15 10:39 ` Nimrod Oren [this message]
2026-11-15 20:59 ` Dimitri Daskalakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf3a990-c9a7-4bf1-a1a7-a2b8976591bc@nvidia.com \
--to=noren@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@kernel.org \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@kernel.org \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox