From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH net] ip6_vti: fix incorrect tunnel matching in vti6_tnl_lookup()
Date: Wed, 10 Jun 2026 09:46:33 +0200 [thread overview]
Message-ID: <bb33e686-c00b-47e1-82a4-716ffb529d5c@6wind.com> (raw)
In-Reply-To: <20260608164613.933023-1-edumazet@google.com>
Le 08/06/2026 à 18:46, Eric Dumazet a écrit :
> In vti6_tnl_lookup(), when an exact match for a tunnel fails,
> the code falls back to searching for wildcard tunnels:
>
> - Tunnels matching the packet's local address, with any remote address
> wildcard remote).
>
> - Tunnels matching the packet's remote address, with any local address
> (wildcard local).
>
> However, vti6 stores all these different types of tunnels in the same
> hash table (ip6n->tnls_r_l) prone to hash collisions.
>
> The bug is that the fallback search loops in vti6_tnl_lookup() were
> missing checks to ensure that the candidate tunnel actually has
> a wildcard address.
>
> Fixes: fbe68ee87522 ("vti6: Add a lookup method for tunnels with wildcard endpoints.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2026-06-10 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 16:46 [PATCH net] ip6_vti: fix incorrect tunnel matching in vti6_tnl_lookup() Eric Dumazet
2026-06-10 7:46 ` Nicolas Dichtel [this message]
2026-06-10 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb33e686-c00b-47e1-82a4-716ffb529d5c@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox