From: Alexandra Winter <wintera@linux.ibm.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Thorsten Winkler <twinkler@linux.ibm.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] net/iucv: Descend into net/iucv when AFIUCV is enabled
Date: Tue, 7 Jul 2026 11:19:09 +0200 [thread overview]
Message-ID: <bb8e0b63-aca1-46ee-9e44-8e6fa46fb98c@linux.ibm.com> (raw)
In-Reply-To: <20260625061303.36326-1-pengpeng@iscas.ac.cn>
On 25.06.26 08:13, Pengpeng Hou wrote:
> AFIUCV can be enabled by the QETH_L3/HiperSockets path even when IUCV
> itself is not enabled. However, the top-level net Makefile only descends
> into net/iucv/ under CONFIG_IUCV.
>
> That creates a Kconfig/Kbuild carrier mismatch: CONFIG_AFIUCV=m can be
> selected, but af_iucv.o is never considered because the containing
> directory is skipped.
>
> This RFC uses an always-descend model for net/iucv/. The subdirectory
> Makefile already gates iucv.o and af_iucv.o on their own Kconfig symbols,
> so entering the directory does not force either provider object on.
>
> This is intentionally RFC because s390 maintainers should confirm whether
> the QETH_L3-only AF_IUCV configuration is intended to build af_iucv.o
> without the base IUCV object.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> net/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/Makefile b/net/Makefile
> --- a/net/Makefile
> +++ b/net/Makefile
> @@ -45,7 +45,7 @@
> obj-$(CONFIG_MAC80211) += mac80211/
> obj-$(CONFIG_TIPC) += tipc/
> obj-$(CONFIG_NETLABEL) += netlabel/
> -obj-$(CONFIG_IUCV) += iucv/
> +obj-y += iucv/
> obj-$(CONFIG_SMC) += smc/
> obj-$(CONFIG_RFKILL) += rfkill/
> obj-$(CONFIG_NET_9P) += 9p/
I apologize for the late reply, I was on vacation.
I'm looking into this now.
May I ask whether you are using IUCV? Or even AFIUCV over HiperSockets?
next prev parent reply other threads:[~2026-07-07 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 6:13 [RFC PATCH] net/iucv: Descend into net/iucv when AFIUCV is enabled Pengpeng Hou
2026-07-07 9:19 ` Alexandra Winter [this message]
2026-07-07 14:54 ` Alexandra Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb8e0b63-aca1-46ee-9e44-8e6fa46fb98c@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengpeng@iscas.ac.cn \
--cc=twinkler@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox