From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"shuah@kernel.org" <shuah@kernel.org>,
"dsahern@gmail.com" <dsahern@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jie2x Zhou <jie2x.zhou@intel.com>,
"Li Zhijian(intel)" <zhijianx.li@intel.com>
Subject: Re: [PATCH v2] selftests: net: Correct case name
Date: Tue, 7 Dec 2021 06:05:58 +0000 [thread overview]
Message-ID: <bbb91e78-018f-c09c-47db-119010c810c2@fujitsu.com> (raw)
In-Reply-To: <20211202022841.23248-1-lizhijian@cn.fujitsu.com>
Hi folks
Currently, LKP/0Day will cover bind tests, but LKP/0DAY observered 3 failures.
> # TESTS=bind ./fcnal-test.sh
> ###########################################################################
> IPv4 address binds
> ###########################################################################
>
>
> #################################################################
> No VRF
>
> TEST: Raw socket bind to local address - ns-A IP [ OK ]
> TEST: Raw socket bind to local address after device bind - ns-A IP [ OK ]
> TEST: Raw socket bind to local address - ns-A loopback IP [ OK ]
> TEST: Raw socket bind to local address after device bind - ns-A loopback IP [ OK ]
> TEST: TCP socket bind to local address - ns-A IP [ OK ]
> TEST: TCP socket bind to local address after device bind - ns-A IP [ OK ]
>
> #################################################################
> With VRF
>
> TEST: Raw socket bind to local address - ns-A IP [ OK ]
> TEST: Raw socket bind to local address after device bind - ns-A IP [ OK ]
> TEST: Raw socket bind to local address after VRF bind - ns-A IP [ OK ]
> TEST: Raw socket bind to local address - VRF IP [FAIL]
>
i found that above case failed with "server: error binding socket: 99: Cannot assign requested address"
i have manually check it with below command after setup(), same errors:
# ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b
05:55:11 server: error binding socket: 99: Cannot assign requested address
But when i specified specific network interface, it works
# ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b -I red
# echo $?
0
# ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b
06:01:55 server: error binding socket: 99: Cannot assign requested address
# echo $?
1
So i wonder if i missed something ?
>
> TEST: Raw socket bind to local address after device bind - VRF IP [ OK ]
> TEST: Raw socket bind to local address after VRF bind - VRF IP [ OK ]
> TEST: Raw socket bind to out of scope address after VRF bind - ns-A loopback IP [ OK ]
> TEST: TCP socket bind to local address - ns-A IP [ OK ]
> TEST: TCP socket bind to local address after device bind - ns-A IP [ OK ]
> TEST: TCP socket bind to local address - VRF IP [ OK ]
> TEST: TCP socket bind to local address after device bind - VRF IP [ OK ]
> TEST: TCP socket bind to invalid local address for VRF - ns-A loopback IP [ OK ]
> TEST: TCP socket bind to invalid local address for device bind - ns-A loopback IP [ OK ]
>
>
>
> # TESTS=bind6 ./fcnal-test.sh
>
> ###########################################################################
> IPv6 address binds
> ###########################################################################
>
>
> #################################################################
> No VRF
>
> TEST: Raw socket bind to local address - ns-A IPv6 [FAIL]
> TEST: Raw socket bind to local address after device bind - ns-A IPv6 [ OK ]
> TEST: Raw socket bind to local address - ns-A loopback IPv6 [ OK ]
> TEST: Raw socket bind to local address after device bind - ns-A loopback IPv6 [ OK ]
> TEST: TCP socket bind to local address - ns-A IPv6 [ OK ]
> TEST: TCP socket bind to local address after device bind - ns-A IPv6 [ OK ]
> TEST: TCP socket bind to out of scope local address - ns-A loopback IPv6 [FAIL]
>
> #################################################################
> With VRF
>
> TEST: Raw socket bind to local address after vrf bind - ns-A IPv6 [ OK ]
> TEST: Raw socket bind to local address after device bind - ns-A IPv6 [ OK ]
> TEST: Raw socket bind to local address after vrf bind - VRF IPv6 [ OK ]
> TEST: Raw socket bind to local address after device bind - VRF IPv6 [ OK ]
> TEST: Raw socket bind to invalid local address after vrf bind - ns-A loopback IPv6 [ OK ]
> TEST: TCP socket bind to local address with VRF bind - ns-A IPv6 [ OK ]
> TEST: TCP socket bind to local address with VRF bind - VRF IPv6 [ OK ]
> TEST: TCP socket bind to local address with device bind - ns-A IPv6 [ OK ]
> TEST: TCP socket bind to VRF address with device bind - VRF IPv6 [FAIL]
> TEST: TCP socket bind to invalid local address for VRF - ns-A loopback IPv6 [ OK ]
> TEST: TCP socket bind to invalid local address for device bind - ns-A loopback IPv6 [ OK ]
Thanks
Zhijian
On 02/12/2021 10:28, Li Zhijian wrote:
> ipv6_addr_bind/ipv4_addr_bind are function names. Previously, bind test
> would not be run by default due to the wrong case names
>
> Fixes: 34d0302ab861 ("selftests: Add ipv6 address bind tests to fcnal-test")
> Fixes: 75b2b2b3db4c ("selftests: Add ipv4 address bind tests to fcnal-test")
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
> index 3313566ce906..7f5b265fcb90 100755
> --- a/tools/testing/selftests/net/fcnal-test.sh
> +++ b/tools/testing/selftests/net/fcnal-test.sh
> @@ -4002,8 +4002,8 @@ EOF
> ################################################################################
> # main
>
> -TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_addr_bind ipv4_runtime ipv4_netfilter"
> -TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_addr_bind ipv6_runtime ipv6_netfilter"
> +TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
> +TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
> TESTS_OTHER="use_cases"
>
> PAUSE_ON_FAIL=no
next prev parent reply other threads:[~2021-12-07 6:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 2:28 [PATCH v2] selftests: net: Correct case name Li Zhijian
2021-12-02 12:20 ` patchwork-bot+netdevbpf
2021-12-07 6:05 ` lizhijian [this message]
2021-12-08 3:01 ` David Ahern
2021-12-08 3:28 ` lizhijian
2021-12-08 3:14 ` David Ahern
2021-12-08 3:38 ` lizhijian
2021-12-08 4:07 ` David Ahern
2021-12-13 3:08 ` Zhou, Jie2X
2021-12-13 4:09 ` David Ahern
2021-12-13 9:44 ` Zhou, Jie2X
2021-12-13 15:58 ` David Ahern
2021-12-15 1:36 ` Zhou, Jie2X
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb91e78-018f-c09c-47db-119010c810c2@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jie2x.zhou@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).