From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH bpf-next 3/4] samples: bpf: fix build after move to compiling full libbpf.a Date: Sun, 13 May 2018 01:22:44 +0200 Message-ID: References: <20180512001729.21634-1-jakub.kicinski@netronome.com> <20180512001729.21634-4-jakub.kicinski@netronome.com> <20180512123757.7970f381@cakuba> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= To: Jakub Kicinski , alexei.starovoitov@gmail.com Return-path: Received: from www62.your-server.de ([213.133.104.62]:37762 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbeELXWq (ORCPT ); Sat, 12 May 2018 19:22:46 -0400 In-Reply-To: <20180512123757.7970f381@cakuba> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/12/2018 09:38 PM, Jakub Kicinski wrote: > On Fri, 11 May 2018 17:17:28 -0700, Jakub Kicinski wrote: >> There are many ways users may compile samples, some of them got >> broken by commit 5f9380572b4b ("samples: bpf: compile and link >> against full libbpf"). Improve path resolution and make libbpf >> building a dependency of source files to force its build. >> >> Samples should now again build with any of: >> cd samples/bpf; make >> make samples/bpf >> make -C samples/bpf >> cd samples/bpf; make O=builddir >> make samples/bpf O=builddir >> make -C samples/bpf O=builddir >> >> Fixes: 5f9380572b4b ("samples: bpf: compile and link against full libbpf") >> Reported-by: Björn Töpel >> Signed-off-by: Jakub Kicinski > > Unfortunately Björn reports this still doesn't fix the build for him. > Investigating further. Ok, thanks for letting us know.