From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07368C43381 for ; Tue, 19 Feb 2019 23:53:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF074206A3 for ; Tue, 19 Feb 2019 23:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dwuKt7bL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730008AbfBSXx4 (ORCPT ); Tue, 19 Feb 2019 18:53:56 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:39181 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727476AbfBSXxy (ORCPT ); Tue, 19 Feb 2019 18:53:54 -0500 Received: by mail-pl1-f195.google.com with SMTP id 101so11212019pld.6 for ; Tue, 19 Feb 2019 15:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UB36a6IcyohLPL43iCqRKlZvnN7GclFjE7P8q6mT3+U=; b=dwuKt7bLicE8mXZ3XFhfs0AcR1REDCMkbfcDygapnu/UxWQ8uNbF0FKabJ6fhFJZhY GA+IjKZgCUCEiX8GK6lczi/1gv630VF6xDbeKE4wwDh3HxRu5QIulaZriznCuEM6cjK1 Qb0zpqTqRTyHPzOOd3bjCsgJCJdfWhcE9HV2AEMjD0hj1iegLu1g3DBfqmdxKL+/dWZN n8qpm3h7p2ZkukFUjNELeieuQk17sMz52fQoXP5h18lkHBgaB5ItOTNkvqlk8orFSF8B y6jy2kuK456VtP62PsorM9ZH5lsojyg+v6Jm65M6V/rZ2NYct8dFk5D07zPUPU24A4RS EAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UB36a6IcyohLPL43iCqRKlZvnN7GclFjE7P8q6mT3+U=; b=BE+Qv51hLH1dYqg3IFI+XNCxe31gL0taPjf7vGsLdjow0D+0YQnPlqdl1NLq8VoMnH 8/kz/S01ppSvPorD68UKS/6fkFLw7Cq3gqbOwUBjEDHVLrUmkt49QxzFDkQXh4v2JkkW PL0fD33FSErTgsNYma91cX3DNmCYzZntrdpInXvpvUfgTHTWHlMmxg/2V8i/ILaMt1CU 7IssJ2i+YXdsqZdZptYu2XjlLFR7XaqP5aZDsxMhUbQTRsZNHFxKeyJhzIo7uXXmbTa4 raOV7kSaWxcYut/VWEHK3b+uT3DOL0goBWYKTCyXo0dqUCMGDVqeOeEF9sV8ib8noxPW zFFQ== X-Gm-Message-State: AHQUAua+ce+QjXNKW7ZrNGRpCe/okHR5LIbFpxRPNDqYLVBSVCJHgFlm F8QfPKnOsPLF1Vlv5VzE7AgdbJcN X-Google-Smtp-Source: AHgI3Ib5WJ7dt6X+bi7qgc6rT1vJyl149H5miR9TvhYd93FzfY96O4stxcIdQ3rjvMyn227bwvtvKg== X-Received: by 2002:a17:902:33c2:: with SMTP id b60mr33495157plc.211.1550620433314; Tue, 19 Feb 2019 15:53:53 -0800 (PST) Received: from [10.67.49.152] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id l12sm35592611pgk.40.2019.02.19.15.53.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 15:53:52 -0800 (PST) Subject: Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags To: Russell King - ARM Linux admin , Vivien Didelot Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org References: <20190217163114.yomawlljyxlqy3ob@shell.armlinux.org.uk> <20190219111612.GF27578@t480s.localdomain> <20190219170059.h5j552kuplvdaqol@shell.armlinux.org.uk> <20190219233408.th2wukhmtxdmeivj@shell.armlinux.org.uk> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 19 Feb 2019 15:53:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190219233408.th2wukhmtxdmeivj@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/19/19 3:34 PM, Russell King - ARM Linux admin wrote: > On Tue, Feb 19, 2019 at 05:00:59PM +0000, Russell King - ARM Linux admin wrote: >> I've just changed my last patch to set these modes from >> dsa_port_bridge_join() and dsa_port_bridge_leave(), and while testing, >> I notice this on the ZII rev B board: >> >> At boot (without anything connected to any of the switch ports): >> >> br0: port 1(lan0) entered blocking state >> br0: port 1(lan0) entered disabled state >> device lan0 entered promiscuous mode >> device eth1 entered promiscuous mode >> br0: port 2(lan1) entered blocking state >> br0: port 2(lan1) entered disabled state >> device lan1 entered promiscuous mode >> ... >> >> I then removed lan0 from the bridge: >> >> device lan0 left promiscuous mode >> br0: port 1(lan0) entered disabled state >> >> and then added it back: >> >> br0: port 1(lan0) entered blocking state >> br0: port 1(lan0) entered disabled state >> device lan0 entered promiscuous mode >> >> Now, you'd expect lan0 and lan1 to be configured the same at this >> point, and the same as it was before lan0 was removed from the bridge? >> lan0 is port 0, lan1 is port 1 on this switch - and the register debug >> says: >> >> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6 >> 0: c800 0 1140 500f 500f 500f 500f 500f 4e07 4d04 >> ... >> 4: 40a8 258 1e0 43c 43d 43d 7c 430 53f 373f >> >> Note that port 0 is in disabled state, but port 1 and 2 are in >> blocking state... but wait, the kernel printed a message saying it was >> in disabled state! >> >> If I do the same for lan1, port 1 above changed from 0x43d to 0x433 as >> expected, and then returns to 0x43c. >> >> It looks like DSA isn't always in sync with bridge as per port state. > > Okay, the problem is what we do when we up the port. > > When the port is added to the bridge device, and it's down, the bridge > code sets the STP state to "disabled". > > Then when we up the interface, dsa_slave_open() calls dsa_port_enable(), > which then decides to change the STP state on its own without reference > to the state assigned by net/bridge: > > int dsa_port_enable(struct dsa_port *dp, struct phy_device *phy) > { > u8 stp_state = dp->bridge_dev ? BR_STATE_BLOCKING : BR_STATE_FORWARDING; > ... > dsa_port_set_state_now(dp, stp_state); > ... > } > > I can understand setting the state to BR_STATE_FORWARDING for > stand-alone ports, but why for bridged ports when the bridge code has > already taken care of configuring the STP state of the port? There was no reason for doing that in commit b73adef67765b72f2a0d01ef15aff9d784dc85da ("net: dsa: integrate with SWITCHDEV for HW bridging") other than copying what rocker had done (which served as model back then), and which got changed the next day in rocker with: e47172ab7e4176883077b454286bbd5b87b5f488 ("rocker: put port in FORWADING state after leaving bridge") Good catch! -- Florian