From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 02/10] r8169: use phy_resume/phy_suspend
Date: Tue, 3 Jul 2018 21:54:38 +0200
Message-ID: <bbf4ac40-5ddd-7a82-411b-82d0a3b5d185@gmail.com>
References: <096a5326-963c-9bef-6218-29fcde004111@gmail.com>
 <318ae669-d89c-636d-94ac-d4c9f662400e@gmail.com>
 <20180702210646.GB12564@lunn.ch>
 <8ef120d3-ac4a-7ffd-2104-76d6f1268105@gmail.com>
 <e8a9e121-9b5d-2e45-2547-148a782e6751@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f195.google.com ([209.85.128.195]:41643 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752874AbeGCTyu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 3 Jul 2018 15:54:50 -0400
Received: by mail-wr0-f195.google.com with SMTP id h10-v6so3113843wrq.8
        for <netdev@vger.kernel.org>; Tue, 03 Jul 2018 12:54:50 -0700 (PDT)
In-Reply-To: <e8a9e121-9b5d-2e45-2547-148a782e6751@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 03.07.2018 18:44, Florian Fainelli wrote:
> 
> 
> On 07/02/2018 02:24 PM, Heiner Kallweit wrote:
>> On 02.07.2018 23:06, Andrew Lunn wrote:
>>>>  static void r8168_pll_power_down(struct rtl8169_private *tp)
>>>>  {
>>>>  	if (r8168_check_dash(tp))
>>>> @@ -4510,7 +4469,8 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
>>>>  	if (rtl_wol_pll_power_down(tp))
>>>>  		return;
>>>>  
>>>> -	r8168_phy_power_down(tp);
>>>> +	/* cover the case that PHY isn't connected */
>>>> +	phy_suspend(mdiobus_get_phy(tp->mii_bus, 0));
>>>
>>> This could do some more explanation. Why would it not be connected?
>>>
>> The PHY gets connected when the net_device is opened. If a network
>> port isn't used then it will be runtime-suspended a few seconds after
>> boot. In this case we call r8168_pll_power_down() with the PHY not
>> being connected. 
> 
> Would not the !netif_running() check in rtl8169_net_suspend() take care
> of that though?
> 
We don't come that far ..
If the interface is down then tp->TxDescArray is NULL. Means we call
rtl_pll_power_down() in rtl8169_runtime_suspend() before reaching
rtl8169_net_suspend().