From: Dan Carpenter <dan.carpenter@linaro.org>
To: Simon Horman <horms@kernel.org>
Cc: Purva Yeshi <purvayeshi550@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
skhan@linuxfoundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kuniyuki Iwashima <kuniyu@amazon.com>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH net-next v2] af_unix: Fix undefined 'other' error
Date: Mon, 17 Feb 2025 17:14:14 +0300 [thread overview]
Message-ID: <bbf51850-814a-4a30-8165-625d88f221a5@stanley.mountain> (raw)
In-Reply-To: <20250217111515.GI1615191@kernel.org>
On Mon, Feb 17, 2025 at 11:15:15AM +0000, Simon Horman wrote:
> So, hypothetically, Smatch could be enhanced and there wouldn't be any
> locking warnings with this patch applied?
Heh. No. What I meant to say was that none of this has anything to do
with Smatch. This is all Sparse stuff. But also I see now that my email
was wrong...
What happened is that we changed unix_sk() and that meant Sparse couldn't
parse the annotations and prints "error: undefined identifier 'other'".
The error disables Sparse checking for the file.
When we fix the error then the checking is enabled again. The v1 patch
which changes the annotation is better than the v2 patch because then
it's 9 warnings vs 11 warnings.
The warnings are all false positives. All old warnings are false
positives. And again, these are all Sparse warnings, not Smatch. Smatch
doesn't care about annotations. Smatch has different bugs completely.
;)
regards,
dan carpenter
next prev parent reply other threads:[~2025-02-17 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 7:50 [PATCH net-next v2] af_unix: Fix undefined 'other' error Purva Yeshi
2025-02-10 17:50 ` Joe Damato
2025-02-11 0:32 ` Kuniyuki Iwashima
2025-02-12 14:24 ` Purva Yeshi
2025-02-12 18:48 ` Jakub Kicinski
2025-02-13 7:44 ` Purva Yeshi
2025-02-15 17:24 ` Simon Horman
2025-02-16 19:33 ` Dan Carpenter
2025-02-17 11:15 ` Simon Horman
2025-02-17 14:14 ` Dan Carpenter [this message]
2025-02-18 13:21 ` Simon Horman
2025-02-18 13:37 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbf51850-814a-4a30-8165-625d88f221a5@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=purvayeshi550@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox