From: <Nicolas.Ferre@microchip.com>
To: <shenyang39@huawei.com>, <davem@davemloft.net>, <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers
Date: Sat, 15 May 2021 12:46:45 +0000 [thread overview]
Message-ID: <bbfb694c-5d48-137c-e394-4d718887f03d@microchip.com> (raw)
In-Reply-To: <1621076039-53986-8-git-send-email-shenyang39@huawei.com>
On 15/05/2021 at 12:53, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Ok, if it raises a warning.
But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c
with same change to a combined patch.
Regards,
Nicolas
> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
> drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index 283918a..5c368a9 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
> * 1588 PTP support for Cadence GEM device.
> *
> * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
> --
> 2.7.4
>
--
Nicolas Ferre
next prev parent reply other threads:[~2021-05-15 12:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
2021-05-15 10:53 ` [PATCH 01/34] net: arc: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 11:06 ` Heiko Stuebner
2021-05-15 10:53 ` [PATCH 02/34] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
2021-05-15 14:21 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 03/34] net: atheros: atl1e: " Yang Shen
2021-05-15 14:23 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 04/34] net: atheros: atl1x: " Yang Shen
2021-05-15 14:25 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 05/34] net: broadcom: bnx2x: " Yang Shen
2021-05-15 10:53 ` [PATCH 06/34] net: brocade: bna: " Yang Shen
2021-05-15 10:53 ` [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 12:46 ` Nicolas.Ferre [this message]
2021-05-17 1:48 ` Yang Shen
2021-05-15 10:53 ` [PATCH 08/34] net: calxeda: Fix wrong function name in comments Yang Shen
2021-05-15 10:53 ` [PATCH 09/34] net: chelsio: cxgb3: " Yang Shen
2021-05-15 10:53 ` [PATCH 10/34] net: chelsio: cxgb4: " Yang Shen
2021-05-15 10:53 ` [PATCH 11/34] net: chelsio: cxgb4vf: " Yang Shen
2021-05-15 10:53 ` [PATCH 12/34] net: huawei: hinic: " Yang Shen
2021-05-15 10:53 ` [PATCH 13/34] net: micrel: " Yang Shen
2021-05-15 10:53 ` [PATCH 14/34] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 10:53 ` [PATCH 15/34] net: neterion: Fix wrong function name in comments Yang Shen
2021-05-15 10:53 ` [PATCH 16/34] net: neterion: vxge: " Yang Shen
2021-05-15 10:53 ` [PATCH 17/34] net: netronome: nfp: " Yang Shen
2021-05-17 9:45 ` Simon Horman
2021-05-15 10:53 ` [PATCH 18/34] net: calxeda: " Yang Shen
2021-05-15 10:53 ` [PATCH 19/34] net: samsung: sxgbe: " Yang Shen
2021-05-15 10:53 ` [PATCH 20/34] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17 2:17 ` Kunihiko Hayashi
2021-05-15 10:53 ` [PATCH 21/34] net: ti: Fix wrong struct name in comments Yang Shen
2021-05-15 10:53 ` [PATCH 22/34] net: via: Fix wrong function " Yang Shen
2021-05-15 10:53 ` [PATCH 23/34] net: phy: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 14:17 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments Yang Shen
2021-05-15 11:36 ` Kalle Valo
2021-05-15 11:37 ` Kalle Valo
2021-05-17 1:51 ` Yang Shen
2021-05-15 10:53 ` [PATCH 25/34] net: ath: " Yang Shen
2021-05-15 10:53 ` [PATCH 26/34] net: ath: wil6210: " Yang Shen
2021-05-15 10:53 ` [PATCH 27/34] net: broadcom: brcmfmac: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 10:53 ` [PATCH 28/34] net: intel: ipw2x00: Fix wrong function name in comments Yang Shen
2021-05-15 10:53 ` [PATCH 29/34] net: intel: iwlwifi: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 10:53 ` [PATCH 30/34] net: marvell: libertas_tf: Fix wrong function name in comments Yang Shen
2021-05-15 10:53 ` [PATCH 31/34] net: realtek: rtlwifi: " Yang Shen
2021-05-15 10:53 ` [PATCH 32/34] net: rsi: Fix missing " Yang Shen
2021-05-15 10:53 ` [PATCH 33/34] net: ti: wl1251: " Yang Shen
2021-05-15 10:53 ` [PATCH 34/34] net: ti: wlcore: " Yang Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbfb694c-5d48-137c-e394-4d718887f03d@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shenyang39@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).