From: Victor Nogueira <victor@mojatatu.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>, Ido Schimmel <idosch@idosch.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
mleitner@redhat.com, vladbu@nvidia.com, paulb@nvidia.com,
pctammela@mojatatu.com, netdev@vger.kernel.org,
kernel@mojatatu.com
Subject: Re: [PATCH net-next v8 1/5] net/sched: Introduce tc block netdev tracking infra
Date: Thu, 28 Dec 2023 11:13:03 -0300 [thread overview]
Message-ID: <bc188893-3d49-4d02-84ad-a85ea399cc92@mojatatu.com> (raw)
In-Reply-To: <CAM0EoMkx6JAUdUdxsMe1hRxBVOQX-R0T+CVT=a3jAdKAxEd7GA@mail.gmail.com>
On 28/12/2023 09:35, Jamal Hadi Salim wrote:
> On Thu, Dec 28, 2023 at 6:50 AM Ido Schimmel <idosch@idosch.org> wrote:
>>
>> On Tue, Dec 19, 2023 at 03:16:19PM -0300, Victor Nogueira wrote:
>>> +static int qdisc_block_add_dev(struct Qdisc *sch, struct net_device *dev,
>>> + struct netlink_ext_ack *extack)
>>> +{
>>> + const struct Qdisc_class_ops *cl_ops = sch->ops->cl_ops;
>>> + struct tcf_block *block;
>>> + int err;
>>> +
>>> + block = cl_ops->tcf_block(sch, TC_H_MIN_INGRESS, NULL);
>>
>> Another problem, shouldn't there be a check that these operations are
>> actually implemented? The following now crashes with a NULL pointer
>> dereference:
>>
>> # tc qdisc replace dev swp1 root handle 1: tbf rate 1Mbit burst 256k limit 1M
>
>
> I think this broke from v7->v8. Thanks for catching this. We'll send a
> fix shortly.
Just sent a fix to net-next because the original patch hasn't been
propagated to net yet.
cheers,
Victor
next prev parent reply other threads:[~2023-12-28 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 18:16 [PATCH net-next v8 0/5] net/sched: Introduce tc block ports tracking and use Victor Nogueira
2023-12-19 18:16 ` [PATCH net-next v8 1/5] net/sched: Introduce tc block netdev tracking infra Victor Nogueira
2023-12-28 11:40 ` Ido Schimmel
2023-12-28 11:50 ` Ido Schimmel
2023-12-28 12:35 ` Jamal Hadi Salim
2023-12-28 14:13 ` Victor Nogueira [this message]
2023-12-19 18:16 ` [PATCH net-next v8 2/5] net/sched: cls_api: Expose tc block to the datapath Victor Nogueira
2023-12-19 18:16 ` [PATCH net-next v8 3/5] net/sched: act_mirred: Create function tcf_mirred_to_dev and improve readability Victor Nogueira
2023-12-19 18:16 ` [PATCH net-next v8 4/5] net/sched: act_mirred: Add helper function tcf_mirred_replace_dev Victor Nogueira
2023-12-19 18:16 ` [PATCH net-next v8 5/5] net/sched: act_mirred: Allow mirred to block Victor Nogueira
2023-12-26 21:30 ` [PATCH net-next v8 0/5] net/sched: Introduce tc block ports tracking and use patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc188893-3d49-4d02-84ad-a85ea399cc92@mojatatu.com \
--to=victor@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=kuba@kernel.org \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=pctammela@mojatatu.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox