From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: for newbies, it would be useful to document values of netdev_state_t Date: Sat, 4 Aug 2018 11:10:34 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: "Robert P. J. Day" , Linux kernel ntedev mailing list Return-path: Received: from mail-oi0-f46.google.com ([209.85.218.46]:40975 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728054AbeHDUMF (ORCPT ); Sat, 4 Aug 2018 16:12:05 -0400 Received: by mail-oi0-f46.google.com with SMTP id k12-v6so15419040oiw.8 for ; Sat, 04 Aug 2018 11:10:36 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 08/04/2018 08:30 AM, Robert P. J. Day wrote: > > i'm sure this is second nature for the experts here, but in > netdevice.h: > > /* These flag bits are private to the generic network queueing > * layer; they may not be explicitly referenced by any other > * code. > */ > > enum netdev_state_t { > __LINK_STATE_START, > __LINK_STATE_PRESENT, > __LINK_STATE_NOCARRIER, > __LINK_STATE_LINKWATCH_PENDING, > __LINK_STATE_DORMANT, > }; > > it would be handy to have a short explanation of what each state > represents, perhaps what combinations are possible and how one moves > from one state to another. This has been like that for some time, and with the exception of the problem you reported in your email before that one, people generally don't muck with that enum, or the state machine consuming it. There might be other places that could deserve better documentation ;) -- Florian