From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v1 3/3] arm: dts: stm32: Add Plymovent AQM devicetree
Date: Sun, 9 Feb 2025 17:36:35 +0100 [thread overview]
Message-ID: <bc413dad-e167-4f4c-9ab2-b2ae77954839@kernel.org> (raw)
In-Reply-To: <20250207143226.2026099-4-o.rempel@pengutronix.de>
On 07/02/2025 15:32, Oleksij Rempel wrote:
> +
> +&spi2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi2_aqm_pins_a>;
> + status = "disabled";
> +
> + spidev@0 {
> + compatible = "dh,dhcom-board"; /* Needed for spidev in userspace */
But that's not a dhcom-board.
NAK, you are abusing DT for instantiating user-space modules. Either you
have here one, fixed, real device or not. If not, you must drop it. If
yes, describe this one, fixed, real device.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-02-09 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 14:32 [PATCH v1 0/3] Add support for Plymovent AQM board Oleksij Rempel
2025-02-07 14:32 ` [PATCH v1 1/3] dt-bindings: sound: convert ICS-43432 binding to YAML Oleksij Rempel
2025-02-07 15:42 ` Rob Herring (Arm)
2025-02-07 14:32 ` [PATCH v1 2/3] dt-bindings: arm: stm32: Add Plymovent AQM board Oleksij Rempel
2025-02-07 14:32 ` [PATCH v1 3/3] arm: dts: stm32: Add Plymovent AQM devicetree Oleksij Rempel
2025-02-09 16:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc413dad-e167-4f4c-9ab2-b2ae77954839@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).