From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH v2 iproute2-next 06/31] tc/util: add print helpers for JSON Date: Mon, 16 Jul 2018 19:05:16 -0600 Message-ID: References: <20180710210558.20278-1-stephen@networkplumber.org> <20180710210558.20278-7-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Stephen Hemminger To: Stephen Hemminger , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:39329 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730002AbeGQBfR (ORCPT ); Mon, 16 Jul 2018 21:35:17 -0400 Received: by mail-pf0-f171.google.com with SMTP id j8-v6so2507420pff.6 for ; Mon, 16 Jul 2018 18:05:20 -0700 (PDT) In-Reply-To: <20180710210558.20278-7-stephen@networkplumber.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 7/10/18 3:05 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Add a helper to print rate, time and size in numeric or pretty format > based on JSON flag. > > Signed-off-by: Stephen Hemminger > --- > tc/tc_util.c | 83 +++++++++++++++++++++++++++++++++------------------- > tc/tc_util.h | 6 ++++ > 2 files changed, 59 insertions(+), 30 deletions(-) This one fails to compile on Stretch: tc CC tc_util.o tc_util.c:388:6: error: conflicting types for ‘print_time’ void print_time(const char *key, const char *fmt, __u32 tm) ^~~~~~~~~~ In file included from tc_util.c:27:0: tc_util.h:92:6: note: previous declaration of ‘print_time’ was here void print_time(const char *key, const char *fmt, __s32 tm); ^~~~~~~~~~ ../config.mk:43: recipe for target 'tc_util.o' failed