From: Paolo Abeni <pabeni@redhat.com>
To: "Csókás Bence" <Csokas.Bence@prolan.hu>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"qiangqing.zhang@nxp.com" <qiangqing.zhang@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH repost] net: fec: Refactor: rename `adapter` to `fep`
Date: Tue, 07 Feb 2023 12:46:48 +0100 [thread overview]
Message-ID: <bc632bea2357e7cd01a6f130a9413fc7e2933af4.camel@redhat.com> (raw)
In-Reply-To: <b0d5ef8d98324e3898a261c3c06ac039@prolan.hu>
Hello,
On Mon, 2023-02-06 at 00:03 +0000, Csókás Bence wrote:
> Commit 01b825f reverted a style fix, which renamed
> `struct fec_enet_private *adapter` to `fep` to match
> the rest of the driver. This commit factors out
> that style fix.
>
> Signed-off-by: Csókás Bence <csokas.bence@prolan.hu>
The patch does not apply cleanly to net-next (nor net, FWIS).
When referencing an existing commit you should use the:
<12 char hash> ("<commit tile>")
format.
More importantly, this kind of refactors are useful if you are going to
touch the relevant code with fixes or new feature in the same series,
otherwise they mainly produces later backport conflicts.
I'm not going to accept this kind of change, sorry.
Paolo
prev parent reply other threads:[~2023-02-07 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 9:49 [PATCH] net: fec: Refactor: rename `adapter` to `fep` Csókás Bence
2022-12-23 2:16 ` Jakub Kicinski
2023-02-06 0:03 ` [PATCH repost] " Csókás Bence
2023-02-07 11:46 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc632bea2357e7cd01a6f130a9413fc7e2933af4.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=Csokas.Bence@prolan.hu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).