From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03490C41604 for ; Tue, 6 Oct 2020 23:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC83920FC3 for ; Tue, 6 Oct 2020 23:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602026462; bh=7jpBLJCbErIbBdEySBbudikYYK8NonWObYz/Np8x4zw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=YTGDGqB6JAq6kONYZmdCx52oDmTKA6Cjc5M6iYS8LA9uuU7v52kh23bGgeznDfiUi Rz+JhGzipix3pfnLWHuUrDwSC3pabbhb5phrTCBh7+JwSdwLV/DQvr76cqX5PpQxDu Ew4Y+s+AlfZBKK9xFdue1Q+mnVtgf4gp2fVJCySs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbgJFXVA (ORCPT ); Tue, 6 Oct 2020 19:21:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:53252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbgJFXU7 (ORCPT ); Tue, 6 Oct 2020 19:20:59 -0400 Received: from lt-jalone-7480.mtl.com (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B44D7208C7; Tue, 6 Oct 2020 23:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602026459; bh=7jpBLJCbErIbBdEySBbudikYYK8NonWObYz/Np8x4zw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Cm/LmKlSvkVACPdYjr3MV9K6dNZbQGnPjX6h1YUH1XFLTUCMpeSOmDfE6tdtDowF4 ddhiwp3VIqsbLGcey2ZCLtm8dfY2oLRTjHwlF9jQq2N8STZGu9sg7mkBTigRkgV2L9 Au4vK8t6kuS+WurDQKewmY9lFfcWUHQPfww0wTH8= Message-ID: Subject: Re: [PATCH][next] net/mlx5: Fix uininitialized pointer read on pointer attr From: Saeed Mahameed To: Colin King , Leon Romanovsky , "David S . Miller" , Jakub Kicinski , "Gustavo A . R . Silva" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 06 Oct 2020 16:20:57 -0700 In-Reply-To: <20201006181243.546661-1-colin.king@canonical.com> References: <20201006181243.546661-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2020-10-06 at 19:12 +0100, Colin King wrote: > From: Colin Ian King > > Currently the error exit path err_free kfree's attr. In the case > where > flow and parse_attr failed to be allocated this return path will free > the uninitialized pointer attr, which is not correct. In the other > case where attr fails to allocate attr does not need to be freed. So > in both error exits via err_free attr should not be freed, so remove > it. > > Addresses-Coverity: ("Uninitialized pointer read") > Fixes: ff7ea04ad579 ("net/mlx5e: Fix potential null pointer > dereference") > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index a0c356987e1a..e3a968e9e2a0 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -4569,7 +4569,6 @@ mlx5e_alloc_flow(struct mlx5e_priv *priv, int > attr_size, > err_free: > kfree(flow); > kvfree(parse_attr); > - kfree(attr); > return err; > } > Applied to net-next-mlx5, Thanks.