Re: [PATCH net-next 07/15] dsa: Add boilerplate helper to register DSA tag driver modules

[Florian Fainelli <f.fainelli@gmail.com>]

On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> A DSA tag driver module will need to register the tag protocols it
> implements with the DSA core. Add a macro containing this boiler plate.
> 
> The registration/unregistration code is currently just a stub. A Later
> patch will add the real implementation.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
[snip]

> diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c
> index 756bade54fee..bff9b03a7752 100644
> --- a/net/dsa/tag_brcm.c
> +++ b/net/dsa/tag_brcm.c
> @@ -205,3 +205,14 @@ struct dsa_device_ops brcm_prepend_netdev_ops = {
>  
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_BRCM_PREPEND);
> +
> +static struct dsa_device_ops *ops_array[] = {
> +#ifdef CONFIG_NET_DSA_TAG_BRCM
> +	&brcm_netdev_ops,
> +	#endif
> +#ifdef CONFIG_NET_DSA_TAG_BRCM_PREPEND
> +	&brcm_prepend_netdev_ops,
> +	#endif
> +};

The indentation for the two #endif is off by one tab here. Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian