From: Cosmin Ratiu <cratiu@nvidia.com>
To: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
Tariq Toukan <tariqt@nvidia.com>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"daniel.zahka@gmail.com" <daniel.zahka@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "sdf.kernel@gmail.com" <sdf.kernel@gmail.com>,
"doruk@0sec.ai" <doruk@0sec.ai>,
Boris Pismenny <borisp@nvidia.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
Jianbo Liu <jianbol@nvidia.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Raed Salem <raeds@nvidia.com>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
Chris Mi <cmi@nvidia.com>, Carolina Jubran <cjubran@nvidia.com>,
"kees@kernel.org" <kees@kernel.org>,
Alex Lazar <alazar@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
"sdf@fomichev.me" <sdf@fomichev.me>,
Saeed Mahameed <saeedm@nvidia.com>,
"horms@kernel.org" <horms@kernel.org>,
"aleksandr.loktionov@intel.com" <aleksandr.loktionov@intel.com>,
Gal Pressman <gal@nvidia.com>, Lama Kayal <lkayal@nvidia.com>,
"Jacob.e.keller@intel.com" <Jacob.e.keller@intel.com>,
Patrisious Haddad <phaddad@nvidia.com>
Subject: Re: [PATCH net-next V2 08/13] net/mlx5e: psp: Handle HW-decapsulated RX PSP packets
Date: Mon, 10 Aug 2026 11:46:46 +0000 [thread overview]
Message-ID: <bc8477dc4d17edd21245d1594e837d6aab17c223.camel@nvidia.com> (raw)
In-Reply-To: <0b3278c9-550e-4b72-8469-00c86180c2ea@gmail.com>
On Tue, 2026-08-04 at 13:34 -0400, Daniel Zahka wrote:
>
>
> On 8/4/26 4:35 AM, Tariq Toukan wrote:
> > #define
> > MLX5E_ACCEL_FLOW_TAG_PROTO_MASK GENMASK(23, 21)
> > @@ -25,6 +27,10 @@
> > #define MLX5E_ACCEL_FLOW_TAG_PROTO_IPSEC (1 << 21)
> > #define MLX5E_ACCEL_FLOW_TAG_PROTO_MACSEC (2 << 21)
> > #define MLX5E_ACCEL_FLOW_TAG_PROTO_PSP (3 << 21)
> > +#define MLX5E_ACCEL_FLOW_TAG_PROTO_PSP_DECAP (4 << 21)
> > +
> > +#define MLX5E_ACCEL_FLOW_TAG_PSP_VER_SHIFT 17
> > +#define MLX5E_ACCEL_FLOW_TAG_PSP_VER_MASK (0xF <<
> > MLX5E_ACCEL_FLOW_TAG_PSP_VER_SHIFT)
>
> [...]
>
> > +static inline u8 mlx5e_psp_get_version(struct mlx5_cqe64 *cqe)
> > +{
> > + return (mlx5e_accel_flow_tag(cqe) &
> > MLX5E_ACCEL_FLOW_TAG_PSP_VER_MASK) >>
> > + MLX5E_ACCEL_FLOW_TAG_PSP_VER_SHIFT;
> > +}
> maybe GENMASK()/FIELD_GET() would help deal with this bitfield?
Thanks, will do in the next version as these make the code much
cleaner. I also added FIELD_PREP in the mix.
Cosmin.
next prev parent reply other threads:[~2026-08-10 11:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 8:35 [PATCH net-next V2 00/13] net/mlx5e: Add support for HW-GRO to PSP Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 01/13] net/mlx5e: Generalize TC <-> IPsec mutual exclusion Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 02/13] net/mlx5e: ipsec: Block TC offload when IPsec is enabled Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 03/13] net/mlx5e: psp: Block TC offload when PSP " Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 04/13] net/mlx5e: macsec: Block TC offload when MACsec " Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 05/13] net/mlx5e: psp: Move RX marker from ft_metadata to flow_tag Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 06/13] net/mlx5e: ipsec: " Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 07/13] net/mlx5e: macsec: " Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 08/13] net/mlx5e: psp: Handle HW-decapsulated RX PSP packets Tariq Toukan
2026-08-04 17:34 ` Daniel Zahka
2026-08-10 11:46 ` Cosmin Ratiu [this message]
2026-08-04 8:35 ` [PATCH net-next V2 09/13] net/mlx5e: psp: Add an rx_decap steering table Tariq Toukan
2026-08-04 17:19 ` Daniel Zahka
2026-08-10 11:48 ` Cosmin Ratiu
2026-08-04 8:35 ` [PATCH net-next V2 10/13] net/mlx5e: shampo: Flush session on PSP mismatch Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 11/13] net/mlx5e: psp: Dynamically reconfigure based on SHAMPO mode Tariq Toukan
2026-08-04 8:35 ` [PATCH net-next V2 12/13] selftests: drv-net: psp: Fix responder parsing Tariq Toukan
2026-08-08 0:58 ` Jakub Kicinski
2026-08-10 11:42 ` Cosmin Ratiu
2026-08-10 20:33 ` Jakub Kicinski
2026-08-04 8:35 ` [PATCH net-next V2 13/13] selftests: drv-net: psp: Add a test for PSP with HW-GRO Tariq Toukan
2026-08-04 18:05 ` Daniel Zahka
2026-08-10 11:52 ` Cosmin Ratiu
2026-08-08 1:00 ` Jakub Kicinski
2026-08-10 14:30 ` Cosmin Ratiu
2026-08-10 20:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8477dc4d17edd21245d1594e837d6aab17c223.camel@nvidia.com \
--to=cratiu@nvidia.com \
--cc=Jacob.e.keller@intel.com \
--cc=alazar@nvidia.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=cjubran@nvidia.com \
--cc=cmi@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=doruk@0sec.ai \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jianbol@nvidia.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkayal@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=raeds@nvidia.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sd@queasysnail.net \
--cc=sdf.kernel@gmail.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox