From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO
Date: Tue, 5 Jun 2018 08:08:24 +0200 [thread overview]
Message-ID: <bca20126-f459-91f0-b91a-1afaa19a168e@gmail.com> (raw)
In-Reply-To: <20180604214829.GA14873@lunn.ch>
On 04.06.2018 23:48, Andrew Lunn wrote:
> On Sat, Jun 02, 2018 at 10:33:36PM +0200, Heiner Kallweit wrote:
>> Current implementation of MDIO bus PM ops doesn't actually implement
>> bus-specific PM ops but just calls PM ops defined on a device level
>> what doesn't seem to be fully in line with the core PM model.
>>
>> When looking e.g. at __device_suspend() the PM core looks for PM ops
>> of a device in a specific order:
>> 1. device PM domain
>> 2. device type
>> 3. device class
>> 4. device bus
>>
>> I think it has good reason that there's no PM ops on device level.
>> The situation can be improved by modeling PHY's as device type of
>> a MDIO device. If for some other type of MDIO device PM ops are
>> needed, it could be modeled as struct device_type as well.
>
> Hi Heiner
>
> I tested that the files in /sys/class/bus/mdio/devices/* are still
> there. And also not there for MDIO devices which are not PHYs,
> e.g. Ethernet switches.
>
> I don't have any boards which do PM. So i cannot test suspend/resume.
>
Thanks for reviewing! I tested suspend / resume by manually suspending
via "systemctl suspend" and resuming via power button or WoL.
The only behavior change I expect is an additional parameter in the PHY
udev calls, see following comment in device.h: If "name" is specified,
the uevent will contain it in the DEVTYPE variable.
This however shouldn't have any impact.
Heiner
> I also took a look at drivers/net/dsa/qca8k.c. This is an MDIO switch
> which has PM operations. I don't think this change will break it.
>
> I would prefer a bit more testing, but i guess that is what -rc
> kernels are for.
>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
> .
>
next prev parent reply other threads:[~2018-06-05 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 20:33 [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO Heiner Kallweit
2018-06-02 20:36 ` [PATCH net-next 1/2] net: phy: add struct device_type representation of a PHY Heiner Kallweit
2018-06-02 20:37 ` [PATCH net-next 2/2] net: phy: remove PM ops from MDIO bus Heiner Kallweit
2018-06-04 19:41 ` [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO David Miller
2018-06-04 21:48 ` Andrew Lunn
2018-06-04 22:06 ` Florian Fainelli
2018-06-05 6:08 ` Heiner Kallweit [this message]
2018-06-05 12:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca20126-f459-91f0-b91a-1afaa19a168e@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).