From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next] net: add network device notifier trace points Date: Wed, 19 Dec 2018 09:48:22 -0700 Message-ID: References: <20181219022706.10611-1-sthemmin@microsoft.com> <20181219083643.7f724e59@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Stephen Hemminger , Daniel Borkmann , Alexei Starovoitov , Arnaldo Carvalho de Melo , Steven Rostedt To: Jesper Dangaard Brouer , Stephen Hemminger Return-path: Received: from mail-pg1-f182.google.com ([209.85.215.182]:37788 "EHLO mail-pg1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbeLSQs1 (ORCPT ); Wed, 19 Dec 2018 11:48:27 -0500 Received: by mail-pg1-f182.google.com with SMTP id c25so8186122pgb.4 for ; Wed, 19 Dec 2018 08:48:26 -0800 (PST) In-Reply-To: <20181219083643.7f724e59@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/19/18 12:36 AM, Jesper Dangaard Brouer wrote: > Today, the existing network tracepoints using dev->name is not that > usable by BPF, as BPF cannot identify the interface. Thus IMHO it would > make sense to convert the existing network tracepoints dev->name into > dev->ifindex, and then let perf-script convert this to the interface > name. Either in userspace via if_indextoname(3), or (as ACME pointed > out at the time) we might want to have a lookup table stored together > with perf.data for later inspection (in-case ifindexes changed). > You need network namespace references as well and the ability to monitor device notifications.