From: Andrew Lunn <andrew@lunn.ch>
To: Romain Gantois <romain.gantois@bootlin.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: phy: dp83869: ensure FORCE_LINK_GOOD is cleared
Date: Tue, 11 Nov 2025 02:03:52 +0100 [thread overview]
Message-ID: <bcf5a9d5-408b-4dd2-9fa3-47861c038183@lunn.ch> (raw)
In-Reply-To: <20251110-sfp-1000basex-v2-2-dd5e8c1f5652@bootlin.com>
On Mon, Nov 10, 2025 at 10:24:54AM +0100, Romain Gantois wrote:
> The FORCE_LINK_GOOD bit in the PHY_CONTROL register forces the reported
> link status to 1 if the selected speed is 1Gbps.
>
> According to the DP83869 PHY datasheet, this bit should default to 0 after
> a hardware reset. However, the opposite has been observed on some DP83869
> components.
>
> As a consequence, a valid link will be reported in 1000Base-X operational
> modes, even if the autonegotiation process failed.
>
> Make sure that the FORCE_LINK_GOOD bit is cleared during initial
> configuration.
>
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-11-11 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 9:24 [PATCH net-next v2 0/3] net: phy: dp83869: Support 1000Base-X SFP Romain Gantois
2025-11-10 9:24 ` [PATCH net-next v2 1/3] net: phy: dp83869: Restart PHY when configuring mode Romain Gantois
2025-11-11 1:02 ` Andrew Lunn
2025-11-10 9:24 ` [PATCH net-next v2 2/3] net: phy: dp83869: ensure FORCE_LINK_GOOD is cleared Romain Gantois
2025-11-11 1:03 ` Andrew Lunn [this message]
2025-11-10 9:24 ` [PATCH net-next v2 3/3] net: phy: dp83869: Support 1000Base-X SFP Romain Gantois
2025-11-11 1:08 ` Andrew Lunn
2025-11-13 9:27 ` Romain Gantois
2026-02-13 12:31 ` [PATCH net-next v2 0/3] " Álvaro G. M.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf5a9d5-408b-4dd2-9fa3-47861c038183@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox