From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:53722 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbeCTUHk (ORCPT ); Tue, 20 Mar 2018 16:07:40 -0400 Received: by mail-wm0-f42.google.com with SMTP id e194so5791813wmd.3 for ; Tue, 20 Mar 2018 13:07:40 -0700 (PDT) Subject: Re: rfc: treewide replace local ethernet broadcast char arrays with a global ? To: Joe Perches , netdev References: <1521576009.12047.17.camel@perches.com> From: Florian Fainelli Message-ID: Date: Tue, 20 Mar 2018 13:07:27 -0700 MIME-Version: 1.0 In-Reply-To: <1521576009.12047.17.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 03/20/2018 01:00 PM, Joe Perches wrote: > Treewide there are ~60 declarations of a ethernet broadcast > address as a 6 byte array that are later used as either an > output for vsprintf extension %pM or as a source array to > copy or compare. > > Perhaps it'd be useful to declare a global static const u8[] > in net somewhere instead to save the text/data space of these > duplicate declarations. I could have sworn that such a thing existed already within include/linux/etherdevice.h but it is only eth_reserved_addr_base and friends as well as is_broadcast_ether_addr(). How about you do it? > > $ grep-2.5.4 -n --include=*.[ch] "\b(?:static\s+)?(?:const\s+)?(?:char|unsigned\s+char|u8)\s+\w+\s*\[\s*(?:ETH_ALEN|6)\s*\]\s*=\s*\{\s*(?:(?i:0xff|255),\s*){5,5}\s*(?i:0xff|255)\s*\}" * | \ > grep -P "\.[ch]:\d+:" > -- Florian