From: Tariq Toukan <tariqt@nvidia.com>
To: Xuanqiang Luo <xuanqiang.luo@linux.dev>,
netdev@vger.kernel.org, tariqt@nvidia.com
Cc: horms@kernel.org, saeedm@nvidia.com, leon@kernel.org,
mbloch@nvidia.com, borisp@nvidia.com, witu@nvidia.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Subject: Re: [PATCH net-next v2] net/mlx5e: kTLS, Simplify error unwind in mlx5e_ktls_set_feature_rx()
Date: Wed, 18 Nov 2026 11:55:30 +0200 [thread overview]
Message-ID: <bd2573cb-3b42-424d-bcd7-09561153d234@nvidia.com> (raw)
In-Reply-To: <20261118025846.3377199-1-xuanqiang.luo@linux.dev>
On 18/11/2026 4:58, Xuanqiang Luo wrote:
> From: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
>
> mlx5e_ktls_set_feature_rx() has become harder to follow: the error
> handling is nested in the conditions and the main flow is conditional.
>
> Handle the disable case first, handle the error cases in conditionals,
> and keep the main flow unconditional. Use goto to unlock on the early
> returns.
>
> No functional change intended.
>
> Suggested-by: Simon Horman <horms@kernel.org>
> Suggested-by: Tariq Toukan <tariqt@nvidia.com>
> Link: https://lore.kernel.org/all/20261029134019.GG257209@horms.kernel.org/
> Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
> ---
> Changes:
> v2:
> - Handle the disable case first and keep the enable argument unchanged,
> instead of reusing it as a flag to destroy the tables. (Suggested by
> Tariq.)
>
> v1: https://lore.kernel.org/all/20261116110830.2850785-1-xuanqiang.luo@linux.dev/
>
Thanks for the update, this is what I had in mind.
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
prev parent reply other threads:[~2026-11-18 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 2:58 [PATCH net-next v2] net/mlx5e: kTLS, Simplify error unwind in mlx5e_ktls_set_feature_rx() Xuanqiang Luo
2026-11-18 9:55 ` Tariq Toukan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd2573cb-3b42-424d-bcd7-09561153d234@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=luoxuanqiang@kylinos.cn \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=witu@nvidia.com \
--cc=xuanqiang.luo@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox